Skip to content

test: fix permissions for test/functional/test.sh#774

Merged
yamgent merged 1 commit into
masterfrom
fix-test-sh-permissions
Mar 18, 2019
Merged

test: fix permissions for test/functional/test.sh#774
yamgent merged 1 commit into
masterfrom
fix-test-sh-permissions

Conversation

@luyangkenneth

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Bug fix

What is the rationale for this request?
The following error shows up when doing npm run test on master. This points to a lack of execution permissions on the local machine (I use a mac).

Screenshot 2019-03-15 at 8 40 42 PM

Upon investigation, it seems that the permissions were modified in #588 (see screenshot below for relevant section of the diff) when moving the then test.sh to a different directory and creating a new test.sh.
Screenshot 2019-03-15 at 8 50 23 PM

What changes did you make?

  1. chmod +x test/functional/test.sh (All our executable files are currently set to 755, except for this one.)
  2. Removed the before_install config in .travis.yml because we shouldn't need it anymore

Testing instructions:

  1. npm run test locally
  2. Tests pass on travis

@yamgent yamgent added this to the v1.20.1 milestone Mar 16, 2019
@yamgent yamgent changed the title [Testing] Fix permissions for test/functional/test.sh test: fix permissions for test/functional/test.sh Mar 16, 2019
@yamgent yamgent merged commit a240f6b into master Mar 18, 2019
@yamgent yamgent deleted the fix-test-sh-permissions branch March 18, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants