test: fix permissions for test/functional/test.sh#774
Merged
Conversation
nicholaschuayunzhi
approved these changes
Mar 15, 2019
yamgent
approved these changes
Mar 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix
What is the rationale for this request?
The following error shows up when doing
npm run teston master. This points to a lack of execution permissions on the local machine (I use a mac).Upon investigation, it seems that the permissions were modified in #588 (see screenshot below for relevant section of the diff) when moving the then

test.shto a different directory and creating a newtest.sh.What changes did you make?
chmod +x test/functional/test.sh(All our executable files are currently set to 755, except for this one.)before_installconfig in.travis.ymlbecause we shouldn't need it anymoreTesting instructions:
npm run testlocally