Improve color theme selection for navbars#797
Conversation
30c8c6f to
f0b3bb8
Compare
yamgent
left a comment
There was a problem hiding this comment.
Propose a merge commit message. Also your associated vue-strap PR have been merged, use the latest master branch to replace vue-strap.min.js?
Btw a side note, actually PR authors shouldn't be the ones re-generating vue-strap.min.js, but right now we don't have a proper packaging system for vue-strap that is specialized for MarkBind, so I can understand the need of re-generating vue-strap.min.js by yourself. In the future, I foresee such updates to be merely just a change in the version number (i.e. modify package.json to up the version number of vue-strap).
f0b3bb8 to
0ded524
Compare
|
Just did a force push 👍 Here's my proposed commit message: |
|
Gave it a try. Nice 👍 |


What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes #386
What is the rationale for this request?
This PR allows users to customize their navbar colors. There is now an option to choose from 3 color schemes that are provided by each bootstrap/bootswatch theme.
There's also an option to specify
type="none", for users who wish to inject their own CSS classes using our existingadd-classfeature.In short,
<navbar>now hastype="primary" | "dark" | "light" | "none", instead oftype="inverse" | "default".What changes did you make? (Give an overview)
<navbar>Testing instructions:
noneor some gibberish value (this will default toprimary), observe that the rendered navbar is styled correctly.