Make Site.js default layout comply with eslint#854
Merged
Conversation
Currently, the default content in Site.js is not compliant with the `no-undef` eslint rule. A comment disabling the offended rule was added.
openorclose
force-pushed
the
default-site-eslint
branch
from
b88cecb to
4a6ea75
Compare
Chng-Zhi-Xuan
approved these changes
May 13, 2019
yamgent
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
Resolves #840
What is the rationale for this request?
Default layout in Site.js is not compliant with MarkBind's eslint rules.
What changes did you make? (Give an overview)
Add a comment disabling the rule