-
Notifications
You must be signed in to change notification settings - Fork 141
Move markdown-it parsing to /markbind #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1b28617
c0d6f3f
18a89d9
0114e66
9180431
59e0a3e
c99bf2f
ba9ad88
26c36a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| *.min.* | ||
| src/lib/markbind/src/lib/markdown-it/* | ||
| src/lib/markbind/src/lib/vue-attribute-renderer/* | ||
| src/lib/markbind/src/lib/markdown-it-shared/* | ||
|
|
||
| !.eslintrc.js | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,6 +136,11 @@ footer { | |
| top: 0; | ||
| } | ||
|
|
||
| /* TODO move this back to markdown-it-attr if bundling is implemented */ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed for markdown-it-dimmed to work which is used in vue-strap version of markdown-it |
||
| .dimmed { | ||
| color: #777; | ||
| } | ||
|
|
||
| /* Bootstrap small(sm) responsive breakpoint */ | ||
| @media (max-width: 767.98px) { | ||
| .dropdown-menu > li > a { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,7 @@ The example paragraph below has the following dynamic elements: a tooltip, a pop | |
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mostly attribute name standardisation for docs, with some misc fixes |
||
| In <tooltip content="Computer Science">CS</tooltip>, a binary tree is a <trigger for="pop:index-tree">tree data structure</trigger> in which each node has at most two children, which are referred to as the _left child_ and the _right child_. <trigger trigger="click" for="modal:index-primitive">Primitive data types</trigger> on the other hand ... | ||
|
|
||
| <popover id="pop:index-tree" title="An example tree data structure" placement="top"> | ||
| <popover id="pop:index-tree" header="An example tree data structure" placement="top"> | ||
| <div slot="content"> | ||
|
|
||
| <br> | ||
|
|
@@ -79,7 +79,7 @@ In <tooltip content="Computer Science">CS</tooltip>, a binary tree is a <trigger | |
| </div> | ||
| </popover> | ||
|
|
||
| <modal large title="Some examples of primitive data types" id="modal:index-primitive"> | ||
| <modal large header="Some examples of primitive data types" id="modal:index-primitive"> | ||
| <include src="pages/primitiveDataTypes.md" /> | ||
| </modal> | ||
|
|
||
|
|
@@ -153,7 +153,7 @@ In CS, a binary tree is a tree data structure in which each node has at most two | |
| <include src="pages/primitiveDataTypes.md" /> | ||
| </panel> | ||
|
|
||
| <modal large title="Some examples of primitive data types" id="modal:index-primitive2"> | ||
| <modal large header="Some examples of primitive data types" id="modal:index-primitive2"> | ||
| <include src="pages/primitiveDataTypes.md" /> | ||
| </modal> | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,15 +74,22 @@ Using the normal syntax, you are only able to use markdown formatting on heading | |
| **Panel Slot Options:** | ||
| Slot name | Default class | Notes | ||
| --- | --- | --- | ||
| `header` | `card-title` | Aligning text to the center of the panel is not possible, as the header element does not take up the entire container. | ||
| header | `card-title` | Aligning text to the center of the panel is not possible, as the header element does not take up the entire container. | ||
|
|
||
| **Modal Slot Options:** | ||
| When using slots for Modals, you need to add a single blank line before each `<modal>` tag, in order for the customization to render correctly. | ||
|
|
||
| Slot name | Default class | Notes | ||
| --- | --- | --- | ||
| `modal-header` | `modal-title` | | ||
| `modal-footer` | `modal-footer` | Specifying `modal-footer` will override the `ok-text` attribute, and the OK button will not render. | ||
| header <hr style="margin-top:0.2rem; margin-bottom:0" /> <small>`modal-header` <br> (deprecated)</small> | `modal-title` | | ||
| footer <hr style="margin-top:0.2rem; margin-bottom:0" /> <small>`modal-footer` <br> (deprecated)</small> | `modal-footer` | Specifying `modal-footer` will override the `ok-text` attribute, and the OK button will not render. | ||
|
|
||
| **Popover Slot Options:** | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed this wasn't there, but was shown in the examples in the popover section, so I added it in |
||
| Slot name | Default class | ||
| --- | --- | --- | ||
| header <hr style="margin-top:0.2rem; margin-bottom:0" /> <small>`title` <br> (deprecated)</small> | `popover-header` | ||
| content | `popover-body` | ||
|
|
||
|
|
||
| ### Inserting custom classes into components | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
| **MarkBind comes with with an in-built _site search_ facility**. You can add a [Search Bar](usingComponents.html#search-bar) component to your pages %%(e.g., into the top navigation bar)%% to allow readers to search your website for keywords. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding information that html headings can also be used for indexing |
||
| </span> | ||
|
|
||
| **All headings of levels 1-3 are captured in the search index** by default. You can change this setting using the [`headingIndexLevel` property of the `site.json`](siteConfiguration.html#headingindexinglevel). | ||
| **All markdown and html headings of levels 1-3 are captured in the search index** by default. You can change this setting using the [`headingIndexLevel` property of the `site.json`](siteConfiguration.html#headingindexinglevel). | ||
|
|
||
| <box type="info"> | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of moving the vue-strap version of markdown-it over