fix(potd): remove letterbox strips around plot of the day image#5943
Merged
Conversation
The 16:10 plot frame in PlotOfTheDayTerminal used `--bg-elevated` as its background, with a hover swap to `--bg-page`. Because the image inside is `object-fit: contain`, non-16:10 plots were letterboxed and those strips above and below the plot picked up the elevated colour — and changed colour on hover, which read as unrelated to the plot. Match the frame background to the surrounding card (`--bg-surface`) and drop the hover colour change. The dashed top/bottom rules remain as the visual separators.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Plot of the Day “terminal” image frame styling to avoid visible letterboxing strips by aligning the frame background with the surrounding card surface and removing the hover background-color swap.
Changes:
- Change the plot frame background from
var(--bg-elevated)tovar(--bg-surface). - Remove the hover background-color change (and its transition) so letterboxed areas don’t “flip” color on hover.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bgcolor: var(--bg-elevated)and a hover swap tovar(--bg-page). Since the image usesobject-fit: contain, non-16:10 plots were letterboxed, and the elevated background showed as light strips above and below the plot — strips that changed colour on hover and read as unrelated to the actual plot.var(--bg-surface)) and drop the hover colour change. The dashed top/bottom rules remain as the visual separators.Test plan
yarn test PlotOfTheDayTerminal --runpassesyarn type-checkpasseshttps://claude.ai/code/session_01YGdKQ58HEtiRKGhaSN1HgC
Generated by Claude Code