Add autotemp capabilities to M104#5223
Closed
FHeilmann wants to merge 2 commits intoMarlinFirmware:RCBugFixfrom
FHeilmann:autotemp_M104
Closed
Add autotemp capabilities to M104#5223FHeilmann wants to merge 2 commits intoMarlinFirmware:RCBugFixfrom FHeilmann:autotemp_M104
FHeilmann wants to merge 2 commits intoMarlinFirmware:RCBugFixfrom
FHeilmann:autotemp_M104
Conversation
This allows M104 to pass the F and B parameters to enable autotemp as well
Contributor
Author
|
One could also avoid code duplication and create a single "autotemp_M109M104()" function |
Member
|
Yes. I would recommend renaming |
Create one autotemp_M104_M109 function instead of two individual functions with duplicate code
Member
|
Thanks! Squashed and will merge #5238 shortly…. |
Contributor
Author
|
While I'm thinking about it. Is autotemp capable of dealing with multiple extruders? Like having separate min/max/factor values for each extruder and setting the temperatures accordingly? |
Member
|
Extruders are still expected to be near-identical in the current Marlin. We don't yet even allow them to have differing steps-per-mm (etc.) values. The issue is that as more indirection is introduced, the more this slows down planner/stepper operations, which are already pushing their performance limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows M104 to pass the F and B parameters to set autotemp parameters similar to M109