compute: remove storage_addr configuration parameter#12742
Merged
Conversation
Contributor
Author
|
This is prep work for MaterializeInc/cloud#2708. It's just stuff that got missed in #12216, so marking for auto merge! |
Since MaterializeInc#12216 separated storage and compute by transiting all data via the persist library, the compute layer no longer needs to communicate directly with the storage layer. So remove the configuration parameters that pertained to the old storage-compute network protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #12216 separated storage and compute by transiting all data via
the persist library, the compute layer no longer needs to communicate
directly with the storage layer. So remove the configuration parameters
that pertained to the old storage-compute network protocol.
Motivation
Testing
Release notes
This PR includes the following user-facing behavior changes: