storage: don't render sources for tables#12779
Merged
Merged
Conversation
Since MaterializeInc#12216, tables are now entirely handled by the controller. There is no longer a need to send a `CreateSourceCommand` to the `storaged` process for table sources. We should eventually adjust the types here to enforce this statically, but this quick fix will unblock MaterializeInc#12770.
petrosagg
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #12216, tables are now entirely handled by the controller. There
is no longer a need to send a
CreateSourceCommandto thestoragedprocess for table sources.
We should eventually adjust the types here to enforce this statically,
but this quick fix will unblock #12770.
Motivation
Testing
Release notes
This PR includes the following user-facing behavior changes: