compute: make import frontier logging drop-safe#18531
Merged
teskje merged 1 commit intoApr 3, 2023
Merged
Conversation
antiguru
requested changes
Mar 31, 2023
antiguru
left a comment
antiguru
left a comment
Member
There was a problem hiding this comment.
I like the idea, but would try to clone less information. This should be doable, but correct me if I'm wrong! Thank you!
teskje
force-pushed
the
drop-safe-import-frontier-logging
branch
from
9a765f1 to
b1c7046
Compare
teskje
force-pushed
the
drop-safe-import-frontier-logging
branch
from
b1c7046 to
4d10e20
Compare
vmarcos
approved these changes
Apr 3, 2023
vmarcos
left a comment
vmarcos
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Only a minor nit on a comment noted below.
This commit adjusts the `LogImportFrontiers` operator to make it emit retractions for previously logged events upon being dropped. This makes that operator safe to use with `drop_dataflow`, or any mechanism that drops dataflows without allowing their operators to shut down gracefully. Without this change, we would leave behind records in the import frontier logging collection.
teskje
force-pushed
the
drop-safe-import-frontier-logging
branch
from
4d10e20 to
825d181
Compare
Contributor
Author
|
TFTRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
LogImportFrontiersoperator to make it emit retractions for previously logged events upon being dropped. This makes that operator safe to use withdrop_dataflow, or any mechanism that drops dataflows without allowing their operators to shut down gracefully. Without this change, we would leave behind records in the import frontier logging collection.Motivation
Advances MaterializeInc/database-issues#835.
Tips for reviewer
A test is provided in #18442. I can't add one here because we don't have a way to spontaneously drop dataflows yet.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.