Mark ReductionPushdown and ReduceElision WMR-safe#18554
Merged
Conversation
ggevay
added
A-optimization
Contributor
|
Tagging @MaterializeInc/qa for a review. |
5 tasks
Contributor
|
I will work on this today. Apologies for the delay. |
philip-stoev
approved these changes
Apr 5, 2023
philip-stoev
left a comment
philip-stoev
left a comment
Contributor
There was a problem hiding this comment.
No wrong results or panics with WMR. The only plan changes are the removal of Distinct, which I guess is expected.
Contributor
Author
|
Great, thank you very much! |
Note that ReduceElision will get smarter once we add a fixpoint loop into the `LetRec` case of the unique key inference. Fixes #18170, #18171
ggevay
force-pushed
the
wmr-reduction-pushdown
branch
from
5338639 to
51dd430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just marks
ReductionPushdownandReduceElisionto be WMR-safe, and adds slts for both.Note that unique key inference is not very smart yet for WMR, which is affecting
ReduceElision, as shown by the last test inreduce_elision.slt. I opened a separate issue for that, and will work on this next. But there are already some situations when bothReductionPushdownandReduceElisionkick in, so we can merge this PR in itself.Motivation
Tips for reviewer
I suggest reviewing the test for pushdown before elision, because the elision tests are similar, but more complicated.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.