compute*: command history metrics#19964
Merged
Merged
Conversation
teskje
force-pushed
the
compute-history-metrics
branch
from
d733555 to
7833ebb
Compare
5 tasks
This commit adds command history metrics to the compute controller: * count of commands, by command type * count of dataflows In addition, this commit modifies the existing replica metrics to be consistent with the controller metrics. This includes adjusting their names and adding a command type label to the command count metric.
This commit updates the mzcompose test that verifies that the compute command history doesn't grow unexpectedly. Specifically it: * ... adjusts for the renamed replica metrics * ... adds testing of the controller history as well
teskje
force-pushed
the
compute-history-metrics
branch
from
7833ebb to
df487a1
Compare
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds command history metrics to the compute controller as proposed in the design doc (#19717):
In addition, this PR modifies the existing replica metrics to be consistent with the controller metrics. This includes adjusting their names and adding a command type label to the command count metric.
Motivation
Part of MaterializeInc/database-issues#5547.
Closes MaterializeInc/database-issues#4621.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.