compute: adjust reconciliation metrics#20939
Merged
Merged
Conversation
teskje
force-pushed
the
reconciliation-metrics
branch
from
01f2765 to
5f635ce
Compare
Contributor
Author
|
I think all failing tests are unrelated to the changes in this PR, so this should be ready to review. |
umanwizard
approved these changes
Aug 2, 2023
This commit makes two adjustments to the compute reconciliation metrics: * renames them to bring them in line with the Prometheus naming conventions * adds a `worker_id` label to bring them in line with the other metrics exported by replicas
teskje
force-pushed
the
reconciliation-metrics
branch
from
5f635ce to
a0f741a
Compare
Contributor
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two adjustments to the compute reconciliation metrics, as proposed in the design doc.
worker_idlabel to bring them in line with the other metrics exported by replicasMotivation
Part of MaterializeInc/database-issues#5547.
Tips for reviewer
This includes a metrics rename, so it can potentially break existing metrics. I doubt that any dashboard uses reconciliation metrics currently, but I will find a way to verify this.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.