Control arrangement merging with default_exert_logic#23029
Merged
Conversation
819841b to
df45314
Compare
754b453 to
61c1df8
Compare
|
This PR has higher risk. Make sure to carefully review the file hotspots. In addition to having this change reviewed, adequate tests should be considered and it may be useful to add observability and/or a feature flag. What's This?
Buggy File Hotspots:
|
61c1df8 to
1189134
Compare
default_extert_logicdefault_exert_logic
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
1189134 to
78d8b34
Compare
umanwizard
suggested changes
Nov 9, 2023
umanwizard
left a comment
Contributor
There was a problem hiding this comment.
The idea sounds fine, but I can't actually evaluate what this does without reading the internals of Differential
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
umanwizard
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an alternative merging strategy for arrangements.
Up to this point, we could either not merge arrangements outside of ingesting updates, or always keep them in the most compacted form by specifying
idle_merge_effort. Since TimelyDataflow/differential-dataflow#411 landed, Differential offers to replace the whole exertion logic, which we conditionally do with this PR. When the idle merge effort is 0, we honor an alternative setting of default_arrangement_exert_proprotionality that specifies which batches in an arrangement should be merged. Specifically, the proportionality determines when to merge the largest with the next largest batch.Motivation
Advanced MaterializeInc/database-issues#4918
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.