Use new merge batcher, remove ValOwned#26821
Merged
Merged
Conversation
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
antiguru
force-pushed
the
new_merge_batcher
branch
from
f802095 to
2880cf3
Compare
antiguru
force-pushed
the
new_merge_batcher
branch
from
339aae3 to
50b2100
Compare
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
frankmcsherry
approved these changes
May 6, 2024
frankmcsherry
left a comment
frankmcsherry
left a comment
Contributor
There was a problem hiding this comment.
Looks good. A few comments, but otherwise good to go!
| T2: for<'a> Trace< | ||
| Key<'a> = T1::Key<'a>, | ||
| ValOwned = T1::ValOwned, | ||
| Val<'a> = T1::Val<'a>, |
Contributor
There was a problem hiding this comment.
Future discussion point: is this the right constraint, or that V can be produced from T1::Val and accepted into T2?
Member
Author
There was a problem hiding this comment.
At the moment, we need a function to go from T1::Val -> V and T2::Val -> V. We could have two functions .. but it seems they're the same anyways, so the equality constraint doesn't seem to be too bad?
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase on current timely and differential:
This introduces a
ConsolidatingContainerBuilderthat consolidates its contents in-place, which eliminates the need for theConsolidateBuffer. The PR thus removes this type.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.