Skip to content

Cluster node recovery test, set kind node image for all nodes.#32714

Merged
def- merged 1 commit into
MaterializeInc:mainfrom
alex-hunt-materialize:explicitly_set_kind_node_image_for_all_nodes
Jun 11, 2025
Merged

Cluster node recovery test, set kind node image for all nodes.#32714
def- merged 1 commit into
MaterializeInc:mainfrom
alex-hunt-materialize:explicitly_set_kind_node_image_for_all_nodes

Conversation

@alex-hunt-materialize

@alex-hunt-materialize alex-hunt-materialize commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Explicitly set the node image for all kind nodes in the cluster node recovery tests.

Motivation

  • This PR fixes a previously unreported bug.
    If not specified, kind will choose the latest node image supported by that kind version. This is a moving target if developers have different versions of kind, and can just fail if we set the node image for some nodes but not others. If the version set for some nodes is old, the auto-selected version for the nodes not set may be more than one minor version newer than the one that was explicitly set, which is not supported by kubeadm (the kubeadm version is chosen by kind to be the version of the highest node version in the cluster).

This is a follow up to #32710 which should prevent this failure in the future (we'll still want to upgrade nodes from time to time, though).

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@alex-hunt-materialize alex-hunt-materialize marked this pull request as ready for review June 11, 2025 11:49
@def- def- merged commit 242fe9c into MaterializeInc:main Jun 11, 2025
13 of 15 checks passed
@alex-hunt-materialize alex-hunt-materialize deleted the explicitly_set_kind_node_image_for_all_nodes branch June 11, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants