Cluster node recovery test, set kind node image for all nodes.#32714
Merged
def- merged 1 commit intoJun 11, 2025
Merged
Conversation
def-
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set the node image for all kind nodes in the cluster node recovery tests.
Motivation
If not specified, kind will choose the latest node image supported by that kind version. This is a moving target if developers have different versions of kind, and can just fail if we set the node image for some nodes but not others. If the version set for some nodes is old, the auto-selected version for the nodes not set may be more than one minor version newer than the one that was explicitly set, which is not supported by kubeadm (the kubeadm version is chosen by kind to be the version of the highest node version in the cluster).
This is a follow up to #32710 which should prevent this failure in the future (we'll still want to upgrade nodes from time to time, though).
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.