[SS-69] use updated iceberg-rust fork. new auth hooks for S3 Tables REST and S3 FileIO#36557
Closed
ublubu wants to merge 1 commit into
Closed
[SS-69] use updated iceberg-rust fork. new auth hooks for S3 Tables REST and S3 FileIO#36557ublubu wants to merge 1 commit into
ublubu wants to merge 1 commit into
Conversation
ublubu
changed the title
ublubu
changed the title
ublubu
force-pushed
the
new-iceberg-rust
branch
4 times, most recently
from
66f9270 to
72e0d8f
Compare
ublubu
commented
May 18, 2026
Comment on lines
+207
to
+213
| if !new_query.is_empty() { | ||
| let url = req.url_mut(); | ||
| let mut pairs = url.query_pairs_mut(); | ||
| for (name, value) in new_query { | ||
| pairs.append_pair(name, &value); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Claude wrote this section a little different from what @DAlperin had. I'm curious if there were problems with just appending the new SigV4 query params (instead of making sure to clobber any conflicting preexisting query params).
ublubu
changed the title
Contributor
Author
|
closing in favor of #36692 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for sinking to GCP's Lakehouse, I've pulled in the stable release
v0.9.0foriceberg-rustand added aRequestAuthenticatortrait for customizing auth support.Auth options:
iceberg-rustfork)gcp_authin an upcoming PR)This PR is still in Draft state because it depends on
iceberg-rustchanges that have not yet been reviewed. (e.g. MaterializeInc/iceberg-rust#1)