storage-types: redact credentials in ContentSource Debug#36703
Open
def- wants to merge 1 commit into
Open
Conversation
def-
force-pushed
the
pr-debug2
branch
2 times, most recently
from
823f6ca to
9271aae
Compare
Use SensitiveUrl for ContentSource::Http and skip the AwsConnection field in Debug so reconcile log lines no longer leak url passwords or inline AWS credentials. Also narrow the storage_state reconcile log to ids only. Carry SensitiveUrl through HttpOneshotSource and HttpObject so the `tracing::info!(?object, "found objects")` line in the HTTP oneshot source also redacts. Move URL-userinfo Basic auth into a Basic auth header before handing the URL to reqwest, so reqwest::Error::Display cannot leak the password on connect/DNS failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SensitiveUrl for ContentSource::Http and skip the AwsConnection field in Debug so reconcile log lines no longer leak url passwords or inline AWS credentials. Also narrow the storage_state reconcile log to ids only.
Carry SensitiveUrl through HttpOneshotSource and HttpObject so the
tracing::info!(?object, "found objects")line in the HTTP oneshot source also redacts. Move URL-userinfo Basic auth into a Basic auth header before handing the URL to reqwest, so reqwest::Error::Display cannot leak the password on connect/DNS failures.