storage-types: implement AlterCompatible for SqlServerSourceExportDetails#36704
Merged
Conversation
…ails The variant was added in MaterializeInc#32087 without updating SourceExportDetails::alter_compatible, so any non-identical pair of SqlServer details fell through to the wildcard and returned an error, which crashes clusterd reconciliation via .expect("only alter compatible ingestions permitted"). Mirror the MySql pattern: defer field-level checks to the source render operators. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
martykulma
approved these changes
May 26, 2026
Contributor
martykulma
left a comment
martykulma
left a comment
There was a problem hiding this comment.
looks reasonable, thanks @def- !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variant was added in #32087 without updating
SourceExportDetails::alter_compatible, so any non-identical pair of SqlServer details fell through to the wildcard and returned an error, which crashes clusterd reconciliation via
.expect("only alter compatible ingestions permitted"). Mirror the MySql pattern: defer field-level checks to the source render operators.