Wire storage decoder Glue path and simplify Decoder::new#37132
Open
martykulma wants to merge 1 commit into
Open
Wire storage decoder Glue path and simplify Decoder::new#37132martykulma wants to merge 1 commit into
martykulma wants to merge 1 commit into
Conversation
Drops the legacy (ccsr_client, confluent_wire_format) pair from Decoder::new in favor of taking WriterSchemaProvider directly; the storage decoder constructs the right variant from WireFormat (Glue arm now wired, planner-blocked). Updates bench + avro-decode bin call sites accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the legacy (ccsr_client, confluent_wire_format) pair from
Decoder::newin favor of takingWriterSchemaProviderdirectly.No functional changes, everything continues to work as before (or better).