SS-308 Re-enable old tests hurt by the drop/recreate bug#37143
Open
peterdukelarsen wants to merge 2 commits into
Open
SS-308 Re-enable old tests hurt by the drop/recreate bug#37143peterdukelarsen wants to merge 2 commits into
peterdukelarsen wants to merge 2 commits into
Conversation
peterdukelarsen
changed the title
peterdukelarsen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I recently fixed this mysql drop/create bug: https://linear.app/materializeinc/issue/SS-104/mysql-drop-create-data-corruption.
This matches the same description as this old issue here: https://github.com/MaterializeInc/database-issues/issues/8127.
A lot of tests have been disabled because of this issue, so thought it would be cool to re-enable them.
Closes SS-308
Closes https://github.com/MaterializeInc/database-issues/issues/8127.
Description
Re-enables testdrive tests disabled due to mysql drop/create bug.
I'm intentionally skipping re-enabling one mention of this issue that's in a postgres test because it likely wasn't fixed by this fix.