[catalog] convert mz_comments to BuiltinMaterializedView#37144
Draft
mtabebe wants to merge 1 commit into
Draft
Conversation
Problem: mz_internal.mz_comments is a BuiltinTable. This requires coordinated writes from a single environmentd process, conflicting with the multi-envd goal. Solution: Convert mz_comments to a BuiltinMaterializedView backed by a query over mz_internal.mz_catalog_raw. Each Comment row in the durable catalog has a `CommentObject` key whose variant is the object type and whose inner value carries the id. Testing: - test/sqllogictest/mz_comments.slt lockdown test - test/sqllogictest/comment.slt, oid.slt, information_schema_tables.slt, replacement-materialized-views.slt, mz_catalog_server_index_accounting.slt, catalog_server_explain.slt all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
mz_internal.mz_comments is a BuiltinTable. This requires coordinated writes from a single environmentd process, conflicting with the multi-envd goal.
Solution:
Convert mz_comments to a BuiltinMaterializedView backed by a query over mz_internal.mz_catalog_raw.
Each Comment row in the durable catalog has a
CommentObjectkey whose variant is the object type and whose inner value carries the id.Testing: