Collect DD fix for 5983#5989
Merged
Merged
Conversation
philip-stoev
approved these changes
Mar 5, 2021
philip-stoev
left a comment
philip-stoev
left a comment
Contributor
There was a problem hiding this comment.
All good, no crashes or wrong results specific to this branch. I pushed the test for the issue in question.
Contributor
Author
|
Thanks very much! |
philip-stoev
added a commit
to philip-stoev/materialize
that referenced
this pull request
Apr 6, 2021
* collect DD fix for 5983 * Push test for #5983 Co-authored-by: Philip Stoev <pstoev@materialize.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MaterializeInc/database-issues#1845
The relevant DD PR is TimelyDataflow/differential-dataflow#311
This change is