Skip to content

Turn off stats by default (hopefully temporarily)#6312

Closed
umanwizard wants to merge 4 commits into
MaterializeInc:mainfrom
umanwizard:no_stats
Closed

Turn off stats by default (hopefully temporarily)#6312
umanwizard wants to merge 4 commits into
MaterializeInc:mainfrom
umanwizard:no_stats

Conversation

@umanwizard

@umanwizard umanwizard commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

This change is Reviewable

@cirego cirego left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for posting this PR! A heads up, a number of testdrive test cases are going to start failing, as well as a test case in catalog/compat. I'm happy to drive those changes if you'd like!

@benesch benesch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you file a tracking issue for this?

@umanwizard

Copy link
Copy Markdown
Contributor Author

Yes @benesch I'm in the process of doing so now.

@cirego that'd be great, if you already know how to fix the failing tests off the top of your head feel free to take it over.

@umanwizard

Copy link
Copy Markdown
Contributor Author

Issue filed: MaterializeInc/database-issues#1951

@cirego

cirego commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

Yes @benesch I'm in the process of doing so now.

@cirego that'd be great, if you already know how to fix the failing tests off the top of your head feel free to take it over.

I pushed a commit that should fixup all of the tests. Will watch the results and see if I missed anything.

@umanwizard

Copy link
Copy Markdown
Contributor Author

let's hold off on landing this because I think I might have a fix for the underlying issue

@umanwizard

Copy link
Copy Markdown
Contributor Author

@cirego #6315 seems to be the proper fix. Closing this out -- sorry for the wasted effort on your part.

@umanwizard umanwizard closed this Apr 2, 2021
@cirego

cirego commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

@cirego #6315 seems to be the proper fix. Closing this out -- sorry for the wasted effort on your part.

No need to apologize -- I'm glad we found the underlying issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants