Skip to content

Refuse to set statistics.interval.ms on RT timestamping connector #6315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umanwizard merged 2 commits into from
Apr 2, 2021
Merged

Refuse to set statistics.interval.ms on RT timestamping connector #6315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
552226f
Refuse to set statistics.interval.ms on RT timestamping connector
umanwizard Apr 2, 2021
9e3b8c3
Periodically poll RT consumer
umanwizard Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/coord/src/timestamp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,9 @@ impl Timestamper {
id: GlobalId,
kc: KafkaSourceConnector,
) -> Option<RtKafkaConnector> {
// These keys do not make sense for the timestamping connector, and will
// be filtered out (fixes #6313)
const CONF_DENYLIST: &'static [&'static str] = &["statistics.interval.ms"];
let mut config = ClientConfig::new();
config.set("bootstrap.servers", &kc.addrs.to_string());

Expand All @@ -639,7 +642,9 @@ impl Timestamper {
}

for (k, v) in &kc.config_options {
config.set(k, v);
if !CONF_DENYLIST.contains(&k.as_str()) {
config.set(k, v);
}
}

let consumer = match config.create::<BaseConsumer>() {
Expand Down Expand Up @@ -931,6 +936,9 @@ fn rt_kafka_metadata_fetch_loop(c: RtKafkaConnector, consumer: BaseConsumer, wai
}
}

// Poll once to clear any extraneous messages on this queue.
consumer.poll(Duration::from_secs(0));

if current_partition_count > 0 {
thread::sleep(wait);
} else {
Expand Down