Document the S3 GetObject optimization#6375
Merged
benesch merged 1 commit intoApr 8, 2021
Merged
Conversation
benesch
reviewed
Apr 7, 2021
| |-----------------------|------------------------------------------------------------------------------------------| | ||
| | All | [`GetObject` permission][getobject] for the objects that they will download | | ||
| | **BUCKET SCAN** | [`ListObject` permission][listobject] for the buckets it will scan | | ||
| | **BUCKET SCAN** | [`ListObject` permission][listobject] for the buckets it will scan, **unless** the `MATCHING` pattern can only list a single object, in which cas materialize will only perform the necessary `GetObject` API call. | |
Contributor
There was a problem hiding this comment.
typo: "cas" -> "case"
Also, Materialize needs to be capitalized in the docs! Always always, unless you are referring to materialized the binary.
And minor nit: "unless the MATCHING pattern can only match a single object" is clearer I think; "list" isn't really a verb that can apply to a pattern but "match" of course is.
Contributor
There was a problem hiding this comment.
+1 to @benesch's comments. I'd also break the final clause into its own sentence: "In such cases, Materialize will only perform the necessary GetObject API call."
msudberg
approved these changes
Apr 8, 2021
Contributor
|
I'm just going to knock these changes out! |
benesch
force-pushed
the
doc-s3-getobject-optimization
branch
from
ff7c954 to
b70c545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in #6314