Skip to content

Use replace_wl_with_unicode and replace_unicode_with_wl from mathics#9

Merged
rocky merged 5 commits intomasterfrom
use-replace_wl_with_unicode-from-core
Jan 9, 2021
Merged

Use replace_wl_with_unicode and replace_unicode_with_wl from mathics#9
rocky merged 5 commits intomasterfrom
use-replace_wl_with_unicode-from-core

Conversation

@GarkGarcia
Copy link
Copy Markdown
Contributor

This is a follow up to mathics/Mathics#1077.

@GarkGarcia GarkGarcia added the enhancement New feature or request label Jan 8, 2021
@GarkGarcia GarkGarcia requested a review from rocky January 8, 2021 20:50
Copy link
Copy Markdown
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we wil have the issue of updating the inputrc's for things like a` -> AAcuteA

@GarkGarcia
Copy link
Copy Markdown
Contributor Author

Note that we wil have the issue of updating the inputrc's for things like a` -> AAcuteA

I'll try to fix the "ESC sequece alias" column in named-characters-data.csv and generate the inpurc files from there.

@rocky
Copy link
Copy Markdown
Member

rocky commented Jan 8, 2021

Note that we wil have the issue of updating the inputrc's for things like a` -> AAcuteA

I'll try to fix the "ESC sequece alias" column in named-characters-data.csv and generate the inpurc files from there.

Ok. Thanks for the import and working on this. If you want to merge this as is go ahead. If you want to instead fill out the importrc's and then merge that is fine too.

@GarkGarcia
Copy link
Copy Markdown
Contributor Author

Note that we wil have the issue of updating the inputrc's for things like a` -> AAcuteA

I'll try to fix the "ESC sequece alias" column in named-characters-data.csv and generate the inpurc files from there.

Those should be fixed with Mathics3/Mathics3-development-guide@0e5cd01. I'll generate the new inputrc file before merging this.

@GarkGarcia GarkGarcia requested a review from rocky January 9, 2021 00:19
@GarkGarcia
Copy link
Copy Markdown
Contributor Author

@rocky Are the entries in inputrc-unicode tested somewhere? Can we at-least validate that the inputrc files have valid GNU readline syntax?

@GarkGarcia
Copy link
Copy Markdown
Contributor Author

GarkGarcia commented Jan 9, 2021

@rocky Are the entries in inputrc-unicode tested somewhere? Can we at-least validate that the inputrc files have valid GNU readline syntax?

Anyway, I'd appreciate if you could take a look at the updated version of inputrc-unicode. I suspect there are still errors in there.

@rocky
Copy link
Copy Markdown
Member

rocky commented Jan 9, 2021

I don't have anything in place. If you want to add something, please do.

@rocky rocky merged commit f41a7b9 into master Jan 9, 2021
Copy link
Copy Markdown
Member

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky deleted the use-replace_wl_with_unicode-from-core branch August 1, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants