Conversation
Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
|
Hey! Thank you so much for submitting this PR. I wonder if it would be better to do |
Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
|
$ ./.build/arm64-apple-macosx/release/Container-Compose version
Container Compose version v0.5.1
$ ./.build/arm64-apple-macosx/release/Container-Compose --version
v0.5.1
$ docker compose version
Docker Compose version v2.23.0-desktop.1
$ docker compose --version
Docker Compose version v2.23.0-desktop.1I've added a commit to allow for the output to be the same across both invocations. |
You get both! 😄 Output is now: $ ./.build/arm64-apple-macosx/release/Container-Compose version
container-compose version v0.5.1
$ ./.build/arm64-apple-macosx/release/Container-Compose --version
container-compose version v0.5.1 |
|
Sounds good! |
|
I accidentally approved these changes. Please just fix the things i outlined above and then I will merge it |
|
Not quite following, you only want the |
|
No both are great. I just want to keep tight access controls. There isn't a reason for the Version command to be accessible outside the module, so we don't need to make it public. Same for the commandName and version variables, but in that case they should be marked as private. |
Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
Setting the variables to be private - good call. |
|
Thank you so much for your effort. Just a few small nitpicks and then this can get merged. |
By default, objects are marked as internal, so we can actually not put an access control on the structure or its properties and it will automatically be internal. |
Mcrich23
left a comment
There was a problem hiding this comment.
Somehow didn't finish the review before, so i'm just doing that
Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
yeah, the github ui for the "double-submit" for review comments trips me up from time to time too. |
|
Thank you for taking the time to scope it well. |
* fix: add version command and arg Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: standardise the output of version and --version Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: scope version strings Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: scope version command to internal Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: cleanup more scopes Signed-off-by: Andrew Basson <andrew.basson@gmail.com> --------- Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
* fix: add version command and arg Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: standardise the output of version and --version Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: scope version strings Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: scope version command to internal Signed-off-by: Andrew Basson <andrew.basson@gmail.com> * fix: cleanup more scopes Signed-off-by: Andrew Basson <andrew.basson@gmail.com> --------- Signed-off-by: Andrew Basson <andrew.basson@gmail.com>
Closes #8
Adds a version command to the tool.
It would need to be manually updated in Application.swift before release.