summary function updated to correctly extract the full alpha level + test for this added #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est for this added as well
Collaborator
Author
|
@nanxstats, @LittleBeannie, the check is failing but not due to the PR. Please advise |
jdblischak
reviewed
Jun 24, 2024
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
Thanks for the PR! Unfortunately the pkgdown error is caused by this PR. Previously this problematic code was never executed because without $input, it always evaluated to NULL.
✖ Failed to render RMarkdown document.
Quitting from lines 89-101 [unnamed-chunk-4] (story-nph-futility.Rmd)
Caused by error:
! $ operator is invalid for atomic vectors
Backtrace:
▆
1. ├─wieand %>% summary() %>% ...
2. ├─gsDesign2::as_gt(...)
3. ├─base::summary(.)
4. └─gsDesign2:::summary.gs_design(.)| observed <- summary(x) | ||
|
|
||
| expect_equal(attributes(observed)$full_alpha, a_level) | ||
| }) |
LittleBeannie
approved these changes
Jun 26, 2024
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thanks, @yuliasidi for fixing the bug!
jdblischak
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.