The HSD spending function does not work for gs_spending_combo()
#444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleBeannie
changed the title
gs_spending_combo()
LittleBeannie
changed the title
gs_spending_combo()gs_spending_combo()
nanxstats
reviewed
Aug 6, 2024
jdblischak
approved these changes
Aug 6, 2024
| #' gs_spending_combo(par, info = 1:3 / 3) | ||
| #' | ||
| #' par <- list(sf = gsDesign::sfXG3, total_spend = 0.025, param = 0.013) | ||
| #' gs_spending_combo(par, info = 1:3 / 3) |
Collaborator
There was a problem hiding this comment.
It wouldn't be a bad idea to add these examples to the tests. Currently there is only a single test in test-independent-gs_spending_combo.R. Can be done later though
nanxstats
approved these changes
Aug 6, 2024
LittleBeannie
deleted the
443-the-hsd-spending-function-does-not-work-for-gs_spending_combo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.