Follow-up on cleaning up summary() functions
#465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
commented
Sep 6, 2024
| # If the method is COMBO, remove the column of "~HR at bound", and remove AHR from header | ||
| if (method == "combo" && "~hr at bound" %in% names(xy)) | ||
| stop("'~hr at bound' can't be displayed!") | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Since ~hr at bound can't possibly exist in xy, perhaps we can remove this check. It doesn't break any test.
@LittleBeannie I'm not sure if this is the right thing to do.
Collaborator
There was a problem hiding this comment.
Hi @yihui , yes, you are right that ~hr at bound does not exist in xy, because it is not part of the raw output from the MaxCombo test (see screenshot below).
Thanks for the confirmation!
Collaborator
Author
There was a problem hiding this comment.
Okay, then I guess we don't really need the check here. Thanks for letting me know!
yihui
force-pushed
the
summary-followup
branch
from
9174768 to
9f43d60
Compare
LittleBeannie
approved these changes
Sep 6, 2024
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thank you, @yihui ! I will get it merged now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two more changes according to #461 (comment)