Make it possible to disable footnotes via as_gt(footnote = FALSE) #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/as_gt.R
Outdated
| footnote <- parts$footnote | ||
| for (i in seq_along(footnote$content)) { | ||
| att <- footnote$attr[i] | ||
| footnotes <- parts$footnotes |
Collaborator
There was a problem hiding this comment.
Hi @yihui, in gsDesign2, we adhere to the singular form in coding, which aligns with our conventions established a few years ago. If you concur, could you please revert "footnotes" to "footnote" for consistency with the other instances? Thank you!
yihui
force-pushed
the
disable-gt-footnotes
branch
from
c62fd55 to
71aaba3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to disable footnotes (this is for the Shiny app; cc @keaven @LittleBeannie).