Skip to content

Fixed the space or rebound issue - #4146

Merged
Withalion merged 7 commits into
masterfrom
fix/ListViewRebound
Jan 9, 2026
Merged

Fixed the space or rebound issue#4146
Withalion merged 7 commits into
masterfrom
fix/ListViewRebound

Conversation

@kaustuvpokharel

@kaustuvpokharel kaustuvpokharel commented Oct 10, 2025

Copy link
Copy Markdown
Contributor

Case: In featureList whenever flickable is scrolled fast or scrolled out of bound; it rebounds and parks the feature below the "add feature" button awkwardly.

FIx: delete the cachedBuffer altogether. In addition, when scrolling up really fast, the list used to go out of bounds, to fix this I added a threshold for the verticalOvershoot and made the list come back to the first element.

ScreenRecording_12-19-2025.13-40-17_1.MP4

And also tested on MacOS, with the project which was referred in this ticket :

Enregistrement.de.l.ecran.2025-12-19.a.18.02.05.mov

@kaustuvpokharel kaustuvpokharel added this to the 2025.8.0 milestone Oct 10, 2025
@kaustuvpokharel kaustuvpokharel linked an issue Oct 10, 2025 that may be closed by this pull request
@kaustuvpokharel kaustuvpokharel added the ui/ux Related to user interface label Oct 10, 2025
@github-actions

github-actions Bot commented Oct 10, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 18618380989

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 19.631%

Files with Coverage Reduction New Missed Lines %
mm/app/attributes/attributecontroller.cpp 1 76.83%
build-mm-db/core/mm_core_autogen/EWIEGA46WW/moc_merginapi.cpp 3 44.31%
mm/core/merginuserauth.cpp 9 68.24%
mm/core/merginapi.cpp 14 74.98%
Totals Coverage Status
Change from base Build 18284755654: -0.02%
Covered Lines: 13932
Relevant Lines: 70969

💛 - Coveralls

@Withalion

Copy link
Copy Markdown
Collaborator

Rule of thumb, if you are fixing/working on UI show us how it looks/works :)

@kaustuvpokharel

Copy link
Copy Markdown
Contributor Author

I was building the ios still to take the screenshot, was about to attach. Anyway, thanks for the heads-up @Withalion

Comment thread app/qml/layers/MMFeaturesListPage.qml Outdated
Comment thread app/qml/layers/MMFeaturesListPage.qml Outdated
Comment thread app/qml/layers/MMFeaturesListPage.qml Outdated

@Withalion Withalion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "spacer" id is not necessary. Let's see what @tomasMizera thinks about it.

@tomasMizera tomasMizera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kaustuvpokharel, so which of the two cacheBuffer/snapMode fixed the issue? :)

@kaustuvpokharel

Copy link
Copy Markdown
Contributor Author

Hi @kaustuvpokharel, so which of the two cacheBuffer/snapMode fixed the issue? :)

The cacheBuffer fixed it here, and I am explicitly using snapMode which is helping to fall to contentItem on view and not anywhere random i.e. empty spaces or such, so I have kept it for cleaner and safer approach.

@Withalion
Withalion changed the base branch from dev/2025.8.0 to master November 11, 2025 10:00
@gabriel-bolbotina gabriel-bolbotina self-assigned this Dec 4, 2025
@tomasMizera tomasMizera changed the title fixed the space or rebound issue WIP: fixed the space or rebound issue Dec 12, 2025
@tomasMizera tomasMizera removed the ui/ux Related to user interface label Dec 12, 2025
@tomasMizera tomasMizera modified the milestones: 2025.8.0, 2026.1.0 Dec 15, 2025
@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Dec 15, 2025
@Withalion Withalion removed the FROZEN 🥶 do not merge before upcoming release label Dec 18, 2025
@Withalion Withalion removed this from the 2026.1.0 milestone Dec 18, 2025
@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 61601 dmg Expires: 18/03/2026 #6160
linux Build 📬 Mergin Maps 61711 x86_64 Expires: 18/03/2026 #6171
win64 Build 📬 Mergin Maps 53531 win64 Expires: 18/03/2026 #5353
Android Build 📭 Build not yet complete or failed.
iOS Build 📭 Build not yet complete or failed.

@Withalion Withalion changed the title WIP: fixed the space or rebound issue Fixed the space or rebound issue Dec 18, 2025
@Withalion
Withalion self-requested a review December 18, 2025 13:17
Comment thread app/qml/layers/MMFeaturesListPage.qml Outdated
@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 61671 dmg Expires: 19/03/2026 #6167
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 53601 win64 Expires: 19/03/2026 #5360
Android Build 📬 Mergin Maps 747711 APK [armeabi-v7a] Expires: 19/03/2026 #7477
Android Build 📬 Mergin Maps 747751 APK [arm64-v8a] Expires: 19/03/2026 #7477
iOS Build 📬 Build number: 25.12.841811 #8418

@tomasMizera tomasMizera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a proper testing on all platforms, with complicated forms and a special test for the "flicking up" fix

@Withalion
Withalion merged commit 84236b4 into master Jan 9, 2026
8 of 12 checks passed
@Withalion
Withalion deleted the fix/ListViewRebound branch January 9, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing whitespace at the bottom of the features list

4 participants