Value relation rework & more small updates - #4525
Merged
Merged
Conversation
…completer and null values
📦 Build Artifacts Ready
|
Withalion
marked this pull request as ready for review
June 8, 2026 13:26
📦 Build Artifacts Ready
|
Withalion
reviewed
Jun 15, 2026
Comment on lines
+47
to
+62
| /** | ||
| * Parses a QGIS value-relation wire value into a list of key strings. | ||
| * allowMulti=true → "{1,2,3}" becomes ["1","2","3"] | ||
| * allowMulti=false → "1" becomes ["1"] | ||
| * An empty or null input always returns an empty list. | ||
| */ | ||
| Q_INVOKABLE QStringList qgisFormatToArray( const QVariant &qgsValue ) const; | ||
|
|
||
| /** | ||
| * Formats a list of key strings into the QGIS wire value "{k1,k2,...}". | ||
| * allowMulti=true → "["1","2","3"]" becomes ["1","2","3"] | ||
| * allowMulti=true → "["1"]" becomes "1" | ||
| * allowMulti=false → "1" becomes "1" | ||
| * An empty list produces "". | ||
| */ | ||
| Q_INVOKABLE QString arrayToQgisFormat( const QStringList &keys ) const; |
Collaborator
There was a problem hiding this comment.
I still think these should be just static utility functions, not tied to the class
Withalion
changed the title
Coverage Report for CI Build 27942757134Warning No base build found for commit Coverage: 57.601%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Testing progress updateThe following tickets have been tested so far and the results with comments are summarized below.
Open issue:🟠 1. NULL entry not visible in the value map drop-down in MM App — the option added via Add NULL value in QGIS Desktop simply doesn't appear as a selectable choice in the mobile app - Is it correct behavior of application? 🔴 3. Clear button doesn't match the Figma design Screenshot: 
|
Testing progress update
Screen_Recording_20260622_105537.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new way of handling value relation editors. Improves performance and stability.
Changes:
ValueRelationControllerthat performs lookups fromkeytovalue, handles hot reload (filter expression) and conversions from/to QGIS format, e. g."{1,2,3}"to[1,2,3]Todos:
distance(@geometry, @current_geometry) <= 0.000135Other updates:
MMDrawerHeaderandMMListMultiselectDrawermultiselect drawer to make their API easier to useResolves #4255
Resolves #4497
Resolves #4443
Resolves #3297
Resolves #3737
Resolves #4508
Resolves #4505
Resolves #2148 (<- the only limitation is VR fields with filter expression)
Resolves (? needs to be tested) #4504