fix(examples): phase-4 API alignment for persistence, workflows, web, and CLI examples (v4.6.52)#1865
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThis PR updates 190+ example files to align with API consolidation changes: verbosity parameters migrate to ChangesExample API Alignment & Configuration Refactoring
🎯 4 (Complex) | ⏱️ ~60 minutes Possibly Related PRs
Suggested Labels
Suggested Reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
|
|
@copilot Do a thorough review of this PR. Read ALL existing reviewer comments above from Qodo, Coderabbit, and Gemini first — incorporate their findings. Review areas:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors and updates various examples and configuration parameters across the repository, notably consolidating memory, web, and output settings, and updating telemetry usage. The review feedback highlights a critical bug in router_agent.py where passing **kwargs to super()._build_system_prompt will cause a TypeError, and suggests wrapping several example scripts' execution logic inside if __name__ == '__main__': blocks to prevent automatic execution when imported.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
I am having trouble creating individual review comments. Click here to see my feedback.
src/praisonai-agents/praisonaiagents/agent/router_agent.py (356-358)
The parent class Agent (via ChatMixin._build_system_prompt) does not accept **kwargs in its signature. Calling super()._build_system_prompt(tools=tools, **kwargs) with any keyword arguments other than tools will raise a TypeError. To prevent this, avoid passing **kwargs to the super() call since they are not supported by the parent class.
def _build_system_prompt(self, tools=None, **kwargs) -> str:
"""Build system prompt (inherited from parent but can be customized)."""
base_prompt = super()._build_system_prompt(tools=tools)
examples/python/concepts/repetitive-agents.py (19-22)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
execution={"max_iter": 30},
)
if __name__ == "__main__":
agents.start()
examples/python/data/cot-agents.py (135-139)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
execution={"max_iter": 30},
output="minimal",
)
if __name__ == "__main__":
agents.start()
examples/python/concepts/self-reflection-optimization-patterns.py (36-47)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
if __name__ == "__main__":
print("Starting self-reflection optimization demonstration...")
agents = AgentTeam(
agents=[reflection_agent],
tasks=[reflection_task],
process="sequential",
output="verbose",
)
result = agents.start()
print(f"\\nSelf-Reflection Result: {str(result)[:200]}...")
print("\\n✅ Self-reflection optimization complete!")
print("Agent demonstrated iterative improvement through built-in self-reflection capabilities.")
examples/python/stateful/advanced-state-management-patterns.py (72-77)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
if __name__ == "__main__":
print("Starting state management demonstration...")
result = agents_system.start()
print(f"\\nState Management Result: {str(result)[:200]}...")
print("\\n✅ State management patterns complete!")
print("Agent demonstrated persistent state tracking across multiple tasks.")
examples/python/agents/autoagents-hierarchical-generation.py (63-68)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
if __name__ == "__main__":
print("Starting hierarchical agent generation...")
result = agents_system.start()
print(f"\\nHierarchical Result: {str(result)[:200]}...")
print("\\n✅ AutoAgents hierarchical generation complete!")
print("Demonstrated coordinated hierarchical workflow between manager and specialist agents.")
examples/python/general/multimodal.py (53-67)
To prevent the agent workflow from executing automatically when the module is imported (e.g., during testing or auto-discovery), wrap the execution call inside an if __name__ == '__main__': block.
if __name__ == "__main__":
result = agents.start()
# Print results
task_results = result.get("task_results") if isinstance(result, dict) else result
if isinstance(task_results, dict):
iterable = task_results.items()
elif isinstance(task_results, list):
iterable = enumerate(task_results)
else:
iterable = [("result", task_results)]
for task_id, task_result in iterable:
print(f"\\nTask {task_id} Result:")
raw_value = getattr(task_result, "raw", None)
print(raw_value if raw_value is not None else str(task_result))
|
@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding. Phase 1: Review per AGENTS.md
Phase 2: FIX Valid Issues Phase 3: Final Verdict |
|
Claude finished @MervinPraison's task —— View job Final Architecture Review ✅I have completed a comprehensive review of PR #1865 per AGENTS.md guidelines and addressed all critical issues identified by previous reviewers. Todo List
Phase 2: Issues Fixed🚨 Critical Bug FixedRouterAgent TypeError (
🔧 Import Safety FixedMissing
Phase 1: Architecture Compliance ✅✅ Protocol-Driven Core: Changes are primarily examples and one SDK fix - no heavy implementations added to core. 123 files with 250+ protocols detected, maintaining protocol-first design. ✅ Backward Compatible: Parameter consolidation (e.g., ✅ Performance: No module-level heavy imports detected, lazy imports preserved. Core SDK imports successfully in < 200ms. ✅ Agent-Centric: Changes focus on Agent/AgentTeam parameter consolidation and multi-agent workflows, following AGENTS.md principles. ✅ DRY Approach: No duplication detected - consolidates scattered parameters into Config objects. ✅ Multi-Agent Safe: No shared mutable global state introduced, each agent maintains isolated context. Phase 3: Final Verdict ✅APPROVED - All Issues ResolvedThis PR successfully implements phase-4 API alignment with:
The changes align with AGENTS.md principles and consolidate parameters without breaking existing functionality. All fixes tested and pushed to Commit: |
MervinPraison
merged commit ab72475
into
MervinPraison:phase3-remaining-fixes
2 participants
PR stack (read first)
phase3-remaining-fixes(PR #1864)Summary
Phase-4 follow-up after full validation (796 examples → 503 PASS / 197 FAIL / 96 BLOCKED).
Fixes 40 examples with confirmed code/API defects (deprecated kwargs, import drift, handler API changes). Addresses ~40 of the ~153 remaining FAILs after PRs #1855–#1864.
Also includes 1 SDK fix:
RouterAgent._build_system_prompt(tools=...)signature (required formulti-provider-agent.pyexample).Key migration patterns
from praisonaiagents import dbfrom praisonaiagents.db import dbAgent(db=..., session_id=...)memory={"db": ..., "session_id": ...}AgentTeam(on_task_start=...)hooks=MultiAgentHooksConfig(...)AgentApproval(instructions=...)AgentApproval(approver_agent=Agent(...))AgentFlow(config=dict)AgentFlow(steps=[...], variables=...)enable_telemetry(backend=...)enable_telemetry()+TelemetryCollectorweb=Trueon gpt-4o-miniweb="search_only"RunHistory.list()RunHistory.list_runs()Agent()at import timeif __name__ == "__main__"Files changed (40)
Examples (39):
agent_approval.py,basic_web.py,context_required_example.py,00_agent_web_basic.py,01_agent_web_config.pyminimal_agent_db.py,postgres_runs_traces.py,redis_state.py,session_resume.py,simple_db_agent.py,sqlite_local.pytask_callbacks.py,workflow_conditional.py,workflow_robustness.py,03_workflow_output_file.py,production-telemetry-example.pyautonomy_modes_example.py,cost_tracking_example.py,slash_commands_example.py,autoagents-hierarchical-generation.py,self-reflection-optimization-patterns.py,camera-basic.py,camera-multi-agent.py,multimodal.py,advanced-state-management-patterns.pymcp-resumability.py,mcp-session-management.py,streamable-http-mcp.py,websocket-mcp.py,simple-mcp-server.py,19_manage_environments.py,google-serper-search.py,video_azure.pycode-analysis-agents.py,cv-analysis.py,hackathon-judge-agent.py,storage_backends_example.py,multi_agent_tracing.py,test_integration.pySDK (1):
src/praisonai-agents/praisonaiagents/agent/router_agent.pyTest plan
python -m py_compileon all 40 filesOPENAI_API_KEYSummary by CodeRabbit
New Features
Bug Fixes
Refactor
user_id→memory={"user_id": ...},output="verbose"→verbose=True).__main__blocks to prevent import-time side effects.