Lfric2lfric multi cpu test#392
Lfric2lfric multi cpu test#392Juan Manuel Castillo Sanchez (ukmo-juan-castillo) wants to merge 8 commits into
Conversation
Lottie Turner (mo-lottieturner)
left a comment
There was a problem hiding this comment.
It looks like checksum_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_4cpu_azspice_gnu_fast-debug-64bit.txt is the same as checksum_lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_1cpu_azspice_gnu_fast-debug-64bit.txt - have you checked the other new kgos to see if they are the same as their single-cpu equivalents?
|
Hi Juan. Thanks for making those changes - just to note, as per the working practices, the developer should not be resolving comments left by others |
|
Hi Juan Manuel Castillo Sanchez (@ukmo-juan-castillo) , I've been looking at this and #390 (and its core link MetOffice/lfric_core#313 ) and I think that actually this ticket should go on before that pair, rather than the other way round. This is because if the adding of w2 fields have the potential to break multi cpu tests I'd like to have those tests on trunk so that they can be tested against during review. Also, I'm happy to take this for science review (as I think we've discussed at some point?) given I've pretty much done the review already |
PR Summary
Sci/Tech Reviewer: Lottie Turner (@mo-lottieturner)
Code Reviewer: mo-marqh
This PR simply adds rose stem tests to compare running lfric2lfric with multiple CPUs.
Code Quality Checklist
Testing
Test Suite Results - lfric_apps - lfric2lfric_multi_CPU_test/run1
Suite Information
Task Information
✅ succeeded tasks - 106
I just run the lfric2lfric tests as they are the only ones affected by these changes. I compared results with #275 and they do not change. Output generated with 1 CPU and multiple CPUs is the same.
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review