Add theta perturbation parameters to namelist#504
Open
Adrian Lock (Adrian-Lock) wants to merge 7 commits into
Open
Add theta perturbation parameters to namelist#504Adrian Lock (Adrian-Lock) wants to merge 7 commits into
Adrian Lock (Adrian-Lock) wants to merge 7 commits into
Conversation
This was referenced May 20, 2026
Contributor
Author
|
Sorry, got ahead of myself as I'm having trouble with accessing this apps namelist from code, see MetOffice/simulation-systems#634 |
thomasmelvin
approved these changes
May 21, 2026
Contributor
thomasmelvin
left a comment
There was a problem hiding this comment.
All looks good to me
Thomas Bendall (tommbendall)
approved these changes
May 22, 2026
Contributor
Thomas Bendall (tommbendall)
left a comment
There was a problem hiding this comment.
Science Review
This PR adds namelist options to specify the height and magnitude of theta perturbations, which were previously hardwired. Most of the changes involve rolling the namelist option out to the feign_initial_temperature_config in unit-tests
There is nothing controversial here and I'm happy to approve.
mo-cjsmith
approved these changes
May 22, 2026
mo-cjsmith
left a comment
There was a problem hiding this comment.
Initialisation changes look fine.
DanStoneMO
approved these changes
May 22, 2026
Contributor
DanStoneMO
left a comment
There was a problem hiding this comment.
Tested JEDI against this and it runs fine as-is. No linked lfric-jedi PR will be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Thomas Bendall (@tommbendall)
Code Reviewer: Benjamin Went (@MetBenjaminWent)
The initial random perturbations used in idealised simulations to initiate fine scale motion are hardwired in the code. Here we add them to the
initial_temperaturenamelist so they can be varied in magnitude (theta_pert_size) and location in the vertical (between the heightstheta_pert_startandtheta_pert_end). Sadly the code to generate the perturbations is in lfric_core so there has to be a linked PR.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - test_apps_init_pert_nml_arglist_3264_all/run1
Suite Information
Task Information
✅ succeeded tasks - 1511
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review