Add excludePort option#5
Merged
Merged
Conversation
wwqgtxx
requested changes
Apr 2, 2025
| @@ -474,6 +474,26 @@ func (t *NativeTun) rules() []*netlink.Rule { | |||
| } | |||
|
|
|||
| nopPriority := ruleStart + 10 | |||
Author
There was a problem hiding this comment.
the 10 is keep for other rules.
if rule's length greater than 10, the nopPriority will be overlapped.
it shouldn't be hardcode by 10.
There was a problem hiding this comment.
You added a port rule here, so should change +10 to +11 to ensure that there is no overlap.
Hard coding may not be the best solution, but it does work.
prepare for MetaCubeX/mihomo#1769
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare for MetaCubeX/mihomo#1769