feature/add animation to profil box sections#963
Merged
lucidcyborg merged 2 commits intoMetaFam:developfrom Dec 14, 2021
firattale:feature/add-animations-to-profile-sections
Merged
feature/add animation to profil box sections#963lucidcyborg merged 2 commits intoMetaFam:developfrom firattale:feature/add-animations-to-profile-sections
lucidcyborg merged 2 commits intoMetaFam:developfrom
firattale:feature/add-animations-to-profile-sections
Conversation
|
@firattale is attempting to deploy a commit to the MetaFam Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
nice, you pretty much got it right - but as you can see, when the value gets updated, the updated values flashes immediately, followed by fade out and fade in animation. |
Contributor
Author
|
The animation has updated. |
Collaborator
|
Great job! :) |
vidvidvid
added
the
ready-for-review
alalonde
pushed a commit
that referenced
this pull request
Dec 16, 2021
* add animation * Change animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
Adding animation after updating profile sections ( Availability, Timezone, Pronouns)
Please provide the GitHub issue number
#890
Closes #
Follow up Improvement Ideas
Implementation
Describe technical (nontrivial / non-obvious) parts of your code
I created a React hook to keep animation logic separated from component and easily reusable.
Side effects
Assets
[Include screenshots/videos if it makes reviewing easier.]
https://gfycat.com/blindbiggroundbeetle