feat: introduce encryption result version#48
Closed
mikesposito wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closed in favor of #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
versionproperty in theEncryptionResultobject. Adding a version to the encryption result object allows the use of different decryption algorithms or configurations based on it.The current implementation (prior to this PR) is classified as version
1.0, and forEncryptionResultobjects that don't have aversionproperty at all, version 1.0 is inferred: this ensures that the decryption methods of this library can still decrypt old versions.Moreover, this PR also adds a
2.0version, where the encryption key is derived with increased iterations.When encrypting, it is now possible to specify the version (defaults to
2.0).Changes
iterationsoptional argument tokeyFromPasswordwith600000as default valueversionargument toencryptWithDetailwith2.0as the default valueversionargument toencryptWithKeywith2.0as the default value