BREAKING: Remove namespaced permissions#1337
Merged
Merged
Conversation
rekmarks
force-pushed
the
remove-namespaced-permissions
branch
from
9bf9690 to
1ad521c
Compare
rekmarks
force-pushed
the
remove-namespaced-permissions
branch
from
a5ef4f3 to
1faa530
Compare
Member
FrederikBolding
left a comment
FrederikBolding
left a comment
There was a problem hiding this comment.
Overall this looks great - just a few small comments.
This comment was marked as resolved.
This comment was marked as resolved.
Member
I don't see a good reason tbh, there hasn't been any meaningful changes since last release. |
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 26, 2026
## Explanation This fixes an issue in changelogs where changelog entries may be incorrectly moved after merging into the main branch. Given the following (partial) changelog for example: ```md ## [Unreleased] ### Changed - Changelog entry A ([#1234](...)) - Changelog entry B ([#5678](...)) - Changelog entry C ([#1337](...)) ``` After a release, this changelog may look like this: ```diff ## [Unreleased] + ## [1.0.0] ### Changed - Changelog entry A ([#1234](...)) - Changelog entry B ([#5678](...)) - Changelog entry C ([#1337](...)) ``` But if another PR based on the original changelog also adds an entry to the unreleased section like this: ```diff ## [Unreleased] ### Changed - Changelog entry A ([#1234](...)) - Changelog entry B ([#5678](...)) - Changelog entry C ([#1337](...)) + - Changelog entry D ([#0000](...)) ``` The final changelog will look like this, since Git can merge the entry based on the other entries around it: ```md ## [Unreleased] ## [1.0.0] ### Changed - Changelog entry A ([#1234](...)) - Changelog entry B ([#5678](...)) - Changelog entry C ([#1337](...)) - Changelog entry D ([#0000](...)) ``` Here it appears that the release included "entry D", but in reality that was meant to be under the unreleased section. To address this issue, I've added a simple workflow that checks for changelog diffs. It uses a minimal algorithm to parse the markdown files, find entries that are included in unreleased originally, and checks if they still are after merging. If not, the workflow will fail and show an error such as this: > Checking changelog file: packages/some-package/CHANGELOG.md > The following lines added in the PR are missing from the "Unreleased" section after merge: > > - Changelog entry D ([#0000](...)) > > Please update your pull request and ensure that new changelog entries remain in the "Unreleased" section. Long term we should solve this problem by using changesets instead, in which case the unreleased changes will never be merged or conflict with each other, but until we figure out how to implement those in our release workflows, we can use this workflow. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk CI-only change that adds a new workflow gate; main failure mode is false positives/negatives that could block merges. > > **Overview** > Adds a new composite GitHub Action (`check-merge-queue-changelogs`) and Node script to detect when changelog lines introduced in a PR get moved out of the `## [Unreleased]` section after merge (a common merge-queue conflict artifact). > > Updates `lint-build-test.yml` to run a new `validate-changelog-diffs` job on `pull_request` and `merge_group` events, failing the workflow when modified `CHANGELOG.md` files lose newly-added Unreleased entries in the merged result. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ef5a189. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes namespaced permissions from the
PermissionControllerfor the reasons described in #1323. As a consequence, also removes the notion of "target keys", which only existed to support namespaced methods. Controller state is not impacted by these changes.Changes
targetKeyconcepttargetKeyproperty of permission specifications has been renamed totargetName.References
Fixes #1323
Checklist