Skip to content

Migrate KeyringController to BaseControllerV2 #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikesposito merged 19 commits into from
Jun 6, 2023
Merged

Migrate KeyringController to BaseControllerV2 #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e0f1878
feat: supp cacheEncryptionKey and submitEncryptionKey method
mikesposito May 8, 2023
5f9e16a
docs: update jsdoc
mikesposito May 8, 2023
0b1cba7
refactor: migrate KeyringController to BaseControllerV2
mikesposito May 16, 2023
afc2e66
fix: use immer v9
mikesposito May 18, 2023
5ad25f7
rollback: controller parameters change
mikesposito May 18, 2023
f1a8f8f
refactor: change KeyringConfig to KeyringControllerConfig
mikesposito May 18, 2023
fb1a96c
refactor: sync controller state with keyring state
mikesposito May 19, 2023
f303c0b
refactor: no vault sync
mikesposito May 19, 2023
f9e837c
refactor: use state value for isUnlocked
mikesposito May 19, 2023
3efbd4f
refactor: use controller state for test assertions
mikesposito May 19, 2023
21f0252
refactor: remove onLock and onUnlock in favor of events
mikesposito May 19, 2023
e42f23e
refactor: sync mem and persistent store
mikesposito May 25, 2023
4c86fb5
refactor: apply review feedback
mikesposito May 29, 2023
2dc7a3c
refactor: use option bag for constructor
mikesposito May 29, 2023
7d1d265
fix: set immer as prod dependency
mikesposito May 30, 2023
2b78519
fix: add encryption key and salt to memstore
mikesposito May 30, 2023
f3f0807
refactor: remove vault encryptionKey and encryptionSalt from returns
mikesposito Jun 1, 2023
a0d8096
fix: remove forgotten state return
mikesposito Jun 5, 2023
5336c99
Merge branch 'main' into refactor/update-to-basecontroller-v2
mikesposito Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/keyring-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
"@metamask/preferences-controller": "workspace:^",
"async-mutex": "^0.2.6",
"ethereumjs-util": "^7.0.10",
"ethereumjs-wallet": "^1.0.1"
"ethereumjs-wallet": "^1.0.1",
"immer": "^9.0.6"
},
"devDependencies": {
"@ethereumjs/common": "^2.6.1",
Expand Down
Loading