[assets-controllers] Upgrade `TokensController` to fully utilize controller-messenger pattern by MajorLift · Pull Request #3690 · MetaMask/core

Replace callbacks `onNetworkDidChange`, `onTokenListStateChange`, `getNetworkClientById` with messenger actions/events

MajorLift

committed

[token-balances-controller] Adjust tests to updates in tokens-controller

MajorLift

committed

test: Mock `TokenListController:stateChange` event

MajorLift

committed

test: Mock `NetworkController:getNetworkClientById` action handler

MajorLift

committed

Use type assertion to mock `getNetworkClientById` return value

MajorLift

committed

Remove unnecessary `?` operator

MajorLift

committed

Fix typing for `TokensState`

MajorLift

committed

Add `TokensControllerGetStateAction`, `TokensControllerActions` types

MajorLift

committed

test: Adjust tests to updates in tokens-controller

MajorLift

committed

Replace `onPreferencesStateChange` callback with messenger event

MajorLift

committed

Expose `addDetectedTokens` action

MajorLift

committed

test: Use `PreferencesController:stateChange` event instead of `onPreferencesStateChange` callback

MajorLift

committed

[token-detection-controller] Replace tokens-controller callbacks with `getState`, `addDetectedTokens` messenger actions

MajorLift

committed

[token-detection-controller] test: Mock `TokensController:getState`, `TokensController:addDetectedTokens` messenger actions

MajorLift

committed

[token-balances-controller] Rename and export `getDefaultTokenBalancesState`

MajorLift

committed

[token-balances-controller] Replace tokens-controller, preferences-controller callbacks with messenger actions/events.

MajorLift

committed

[token-balances-controller] test: Use `PreferencesController:getState` action, `TokensController:stateChange` event

MajorLift

committed

[token-list-controller,token-rates-controller] Enumerate package-level exports

MajorLift

committed

Add changelog entries

MajorLift

committed

Remove `BaseState` from `TokensState`

MajorLift

committed

test: initialize `getNetworkClientByIdHandler` in `beforeEach`

MajorLift

committed

test: move `addRequestHandler` initialization to individual test

MajorLift

committed

test: rename `registerListeners` to `promiseForApprovals`

MajorLift

committed

Update packages/assets-controllers/CHANGELOG.md

MajorLift

and

mcmire

committed

[token-detection-controller] test: remove unnecessary `as unknown as` cast

MajorLift

committed

[token-detection-controller] Fix `detectTokens` to remove redundant `TokensController:getState` calls for `ignoredTokens`

MajorLift

committed

[token-detection-controller] Fix typing for `STATIC_MAINNET_TOKEN_LIST`

MajorLift

committed

Squashed commit of the following:

MajorLift

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[assets-controllers] Upgrade `TokensController` to fully utilize controller-messenger pattern#3690

[assets-controllers] Upgrade `TokensController` to fully utilize controller-messenger pattern#3690
MajorLift merged 28 commits into
mainfrom
231220-TokensController-v2-migration

Commits on Feb 8, 2024

Replace callbacks `onNetworkDidChange`, `onTokenListStateChange`, `getNetworkClientById` with messenger actions/events

[token-balances-controller] Adjust tests to updates in tokens-controller

test: Mock `TokenListController:stateChange` event

test: Mock `NetworkController:getNetworkClientById` action handler

Use type assertion to mock `getNetworkClientById` return value

Remove unnecessary `?` operator

Fix typing for `TokensState`

Add `TokensControllerGetStateAction`, `TokensControllerActions` types

test: Adjust tests to updates in tokens-controller

Replace `onPreferencesStateChange` callback with messenger event

Expose `addDetectedTokens` action

test: Use `PreferencesController:stateChange` event instead of `onPreferencesStateChange` callback

[token-detection-controller] Replace tokens-controller callbacks with `getState`, `addDetectedTokens` messenger actions

[token-detection-controller] test: Mock `TokensController:getState`, `TokensController:addDetectedTokens` messenger actions

[token-balances-controller] Rename and export `getDefaultTokenBalancesState`

[token-balances-controller] Replace tokens-controller, preferences-controller callbacks with messenger actions/events.

[token-balances-controller] test: Use `PreferencesController:getState` action, `TokensController:stateChange` event

[token-list-controller,token-rates-controller] Enumerate package-level exports

Add changelog entries

Remove `BaseState` from `TokensState`

test: initialize `getNetworkClientByIdHandler` in `beforeEach`

test: move `addRequestHandler` initialization to individual test

test: rename `registerListeners` to `promiseForApprovals`

Update packages/assets-controllers/CHANGELOG.md

[token-detection-controller] test: remove unnecessary `as unknown as` cast

[token-detection-controller] Fix `detectTokens` to remove redundant `TokensController:getState` calls for `ignoredTokens`

[token-detection-controller] Fix typing for `STATIC_MAINNET_TOKEN_LIST`

Squashed commit of the following: