Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

MetaMask / core Public

Notifications You must be signed in to change notification settings
Fork 279
Star 404

Code
Issues 309
Pull requests 277
Actions
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security and quality
Insights

Merge `EthKeyringController` into `KeyringController`#3830

Merged

mikesposito merged 15 commits into

mainMetaMask/core:mainfrom

refactor/merge-keyring-controllersMetaMask/core:refactor/merge-keyring-controllersCopy head branch name to clipboard

Jan 30, 2024

Conversation Commits15 (15)Checks Files changed

Merged

Merge `EthKeyringController` into `KeyringController`#3830
mikesposito merged 15 commits into
mainfrom
refactor/merge-keyring-controllers

Commits

Commits on Jan 29, 2024

merge eth-keyring-controller logic
mikesposito
committed
refactor: rename updateMemStoreKeyrings
mikesposito
committed
chore: use eth-sig-util ^7.0.1
mikesposito
committed
refactor: make createNewVaultWithKeyring private
mikesposito
committed
refactor: drop eth-keyring-controller dependency
mikesposito
committed
fix: port isSerializedKeyringsArray function
mikesposito
committed
test: adjust coverage
mikesposito
committed
refactor: #restoreKeyring function
mikesposito
committed
refactor: remove unreachable branches
mikesposito
committed
test: add hdkeyring test case
mikesposito
committed
refactor: remove `addNewAccount` code repetition
mikesposito
committed
docs: update jsdoc
mikesposito
committed
refactor: remove useless eslint-disable
mikesposito
committed
docs: fix jsdoc
mikesposito
committed
refactor: remove `throwError` util
mikesposito
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.