Skip to content

Support Layer1GasFeeFlows and add layer1GasFee property to TransactionMeta#3944

Merged
OGPoyraz merged 19 commits into
mainfrom
2031-support-layer-1-gas-fee-flows-in-transaction-controller
Mar 13, 2024
Merged

Support Layer1GasFeeFlows and add layer1GasFee property to TransactionMeta#3944
OGPoyraz merged 19 commits into
mainfrom
2031-support-layer-1-gas-fee-flows-in-transaction-controller

Conversation

@OGPoyraz
Copy link
Copy Markdown
Member

Explanation

This PR implements support of Layer1GasFeeFlows and add layer1GasFee property to TransactionMeta

References

Changelog

@metamask/transaction-controller

  • ADDED: Support Layer1GasFeeFlows and add layer1GasFee property to TransactionMeta

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@OGPoyraz OGPoyraz requested a review from a team as a code owner February 21, 2024 12:06
@OGPoyraz OGPoyraz force-pushed the 2031-support-layer-1-gas-fee-flows-in-transaction-controller branch from 1fae4f5 to 39f8d0d Compare February 21, 2024 12:09
Comment thread packages/transaction-controller/src/TransactionController.ts Outdated
dbrans
dbrans previously approved these changes Feb 21, 2024
Copy link
Copy Markdown
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/transaction-controller/src/types.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.test.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.test.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.test.ts Outdated
Comment thread packages/transaction-controller/src/constants.ts
Comment thread packages/transaction-controller/src/helpers/GasFeePoller.ts Outdated
Comment thread packages/transaction-controller/src/helpers/GasFeePoller.ts
Comment thread packages/transaction-controller/src/TransactionController.ts Outdated
Comment thread packages/transaction-controller/src/TransactionController.ts Outdated
dbrans
dbrans previously approved these changes Feb 23, 2024
Copy link
Copy Markdown
Contributor

@dbrans dbrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, Goktug!

@OGPoyraz
Copy link
Copy Markdown
Member Author

@OGPoyraz OGPoyraz added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead and removed DO-NOT-MERGE labels Mar 1, 2024
@OGPoyraz OGPoyraz closed this Mar 1, 2024
@OGPoyraz OGPoyraz reopened this Mar 1, 2024
Comment thread packages/transaction-controller/src/types.ts Outdated
Comment thread packages/transaction-controller/src/helpers/GasFeePoller.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.ts Outdated
Comment thread packages/transaction-controller/src/utils/layer1-gas-fee-flow.test.ts Outdated
Comment thread packages/transaction-controller/src/helpers/GasFeePoller.test.ts Outdated
Comment thread packages/transaction-controller/src/helpers/GasFeePoller.test.ts Outdated
Comment thread packages/transaction-controller/src/constants.ts
Comment thread packages/transaction-controller/src/TransactionController.ts
@OGPoyraz OGPoyraz merged commit d203db7 into main Mar 13, 2024
@OGPoyraz OGPoyraz deleted the 2031-support-layer-1-gas-fee-flows-in-transaction-controller branch March 13, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-confirmations-system DEPRECATED: please use "team-confirmations" label instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants