Release 331.0.0 - #5496
Merged
Merged
Conversation
matthewwalsh0
force-pushed
the
release/331.0.0
branch
from
March 18, 2025 15:19
1b6f5fb to
552b498
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/bridge-controller@7.0.0, npm/@metamask/transaction-controller@49.0.0 |
matthewwalsh0
marked this pull request as ready for review
March 18, 2025 15:23
OGPoyraz
previously approved these changes
Mar 18, 2025
mcmire
previously requested changes
Mar 18, 2025
matthewwalsh0
force-pushed
the
release/331.0.0
branch
from
March 18, 2025 16:50
39cf17d to
6feac73
Compare
mcmire
reviewed
Mar 18, 2025
Comment on lines
+14
to
+21
| - **BREAKING:** Add peer dependency on `^26.0.0` of `@metamask/accounts-controller`([#5470](https://github.com/MetaMask/core/pull/5470)) | ||
| - Add EIP-7702 signature validations ([#5470](https://github.com/MetaMask/core/pull/5470)) | ||
| - Throw if external and `verifyingContract` matches any internal account. | ||
| - Throw if external and `primaryType` is `Delegation` and `delegator` matches any internal EOA account. | ||
|
|
||
| ### Changed | ||
|
|
||
| - Bump `@metamask/accounts-controller` peer dependency to `^26.1.0` ([#5481](https://github.com/MetaMask/core/pull/5481)) |
Collaborator
There was a problem hiding this comment.
Nit: Should we merge the accounts-controller entries? The initial change to introduce 26.0.0 wasn't ever public and then we bumped the dependency to 26.1.0 so we can just say that the peer dependency is 26.1.0.
Suggested change
| - **BREAKING:** Add peer dependency on `^26.0.0` of `@metamask/accounts-controller`([#5470](https://github.com/MetaMask/core/pull/5470)) | |
| - Add EIP-7702 signature validations ([#5470](https://github.com/MetaMask/core/pull/5470)) | |
| - Throw if external and `verifyingContract` matches any internal account. | |
| - Throw if external and `primaryType` is `Delegation` and `delegator` matches any internal EOA account. | |
| ### Changed | |
| - Bump `@metamask/accounts-controller` peer dependency to `^26.1.0` ([#5481](https://github.com/MetaMask/core/pull/5481)) | |
| - **BREAKING:** Add peer dependency on `^26.1.0` of `@metamask/accounts-controller` ([#5470](https://github.com/MetaMask/core/pull/5470), [#5481](https://github.com/MetaMask/core/pull/5481)) | |
| - Add EIP-7702 signature validations ([#5470](https://github.com/MetaMask/core/pull/5470)) | |
| - Throw if external and `verifyingContract` matches any internal account. | |
| - Throw if external and `primaryType` is `Delegation` and `delegator` matches any internal EOA account. |
mcmire
approved these changes
Mar 18, 2025
mcmire
left a comment
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
One nit but all good here regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major releases of:
@metamask/bridge-controller@metamask/bridge-status-controller@metamask/signature-controller@metamask/transaction-controller@metamask/user-operation-controller