Skip to content

fix: batch NFT ownership checks via Multicall3 #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmigdr merged 12 commits into from
Apr 10, 2026
Merged

fix: batch NFT ownership checks via Multicall3 #8281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a7939db
fix: do not make O(n) calls for NFT refresh
juanmigdr Mar 24, 2026
a62cbb4
chore: update changelog
juanmigdr Mar 24, 2026
0892546
Merge branch 'main' into fix/do-not-make-On-calls-fo-refresh
juanmigdr Mar 24, 2026
7b4faee
fix: linting
juanmigdr Mar 24, 2026
5ec8737
fix: minor issue
juanmigdr Mar 25, 2026
10d305c
chore: minor formatting
juanmigdr Mar 25, 2026
7d2a213
Merge branch 'main' into fix/do-not-make-On-calls-fo-refresh
juanmigdr Apr 8, 2026
0ed9859
chore: updated changelog
juanmigdr Apr 8, 2026
1b788d7
Merge branch 'main' into fix/do-not-make-On-calls-fo-refresh
juanmigdr Apr 10, 2026
61161ae
feat: removed unowned NFTs from state
juanmigdr Apr 10, 2026
09a4cdc
chore: minimal change
juanmigdr Apr 10, 2026
f782f90
Merge branch 'main' into fix/do-not-make-On-calls-fo-refresh
juanmigdr Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **BREAKING:** `NftController` no longer uses the `AssetsContractController:getERC721OwnerOf` and `AssetsContractController:getERC1155BalanceOf` messenger actions for ownership checks; these have been removed from `AllowedActions` ([#8281](https://github.com/MetaMask/core/pull/8281))
- Consumers that construct the `NftController` messenger and register handlers for these two actions must remove them from their allowed actions list.
- **BREAKING:** Removed the `checkAndUpdateSingleNftOwnershipStatus` method from `NftController` ([#8281](https://github.com/MetaMask/core/pull/8281))
- Use `checkAndUpdateAllNftsOwnershipStatus` instead, which now batches all ownership checks via Multicall3 in a single RPC request.
- `checkAndUpdateAllNftsOwnershipStatus` now removes NFTs confirmed as unowned from state instead of setting `isCurrentlyOwned: false` ([#8281](https://github.com/MetaMask/core/pull/8281))
- The `isCurrentlyOwned: false` flag was originally used to power a "Previously Owned" NFTs section in MetaMask, which is no longer supported. NFTs that are confirmed as no longer owned are now removed from state immediately rather than being retained with a stale flag.
- `NftController` NFT ownership checks (`isNftOwner`, `checkAndUpdateAllNftsOwnershipStatus`) now use Multicall3 to batch ERC-721 `ownerOf` and ERC-1155 `balanceOf` calls into fewer RPC requests, falling back to individual calls on unsupported chains ([#8281](https://github.com/MetaMask/core/pull/8281))
- Bump `@metamask/accounts-controller` from `^37.1.1` to `^37.2.0` ([#8363](https://github.com/MetaMask/core/pull/8363))
- Bump `@metamask/keyring-controller` from `^25.1.1` to `^25.2.0` ([#8363](https://github.com/MetaMask/core/pull/8363))
- Bump `@metamask/messenger` from `^1.0.0` to `^1.1.1` ([#8364](https://github.com/MetaMask/core/pull/8364), [#8373](https://github.com/MetaMask/core/pull/8373))
Expand Down
Loading
Loading