Skip to content

Ensure refs in tsconfig files are synced with internal deps #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 9 commits into from
Jul 15, 2026
Merged

Ensure refs in tsconfig files are synced with internal deps #8384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
59d1379
Ensure refs in tsconfig files are synced with internal deps
mcmire Feb 26, 2026
0aadda4
Fix types for createPermissionMiddleware
mcmire Jul 10, 2026
f581e73
Sort package.json files
mcmire Jul 10, 2026
567a301
Apply suggestions from code review
mcmire Jul 13, 2026
16d5dc1
Undo .toSorted
mcmire Jul 13, 2026
ecd9a6e
Merge branch 'main' into lint-tsconfig-files
mcmire Jul 13, 2026
c2ef4bb
Merge branch 'main' into lint-tsconfig-files
mcmire Jul 14, 2026
13fb9ef
No need to exclude snap-account-service anymore
mcmire Jul 14, 2026
2886d3b
Merge branch 'main' into lint-tsconfig-files
mcmire Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/lint-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- lint:teams
- messenger-action-types:check
- readme-content:check
- lint:tsconfigs:all
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v3
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ linkStyle default opacity:0.5
earn_controller --> network_controller;
earn_controller --> transaction_controller;
eip_5792_middleware --> messenger;
eip_5792_middleware --> preferences_controller;
eip_5792_middleware --> transaction_controller;
eip_5792_middleware --> keyring_controller;
eip_7702_internal_rpc_middleware --> controller_utils;
Expand Down Expand Up @@ -410,6 +411,7 @@ linkStyle default opacity:0.5
json_rpc_engine --> messenger;
json_rpc_middleware_stream --> json_rpc_engine;
keyring_controller --> base_controller;
keyring_controller --> controller_utils;
keyring_controller --> messenger;
logging_controller --> base_controller;
logging_controller --> controller_utils;
Expand Down
6 changes: 3 additions & 3 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,10 @@ const config = createConfig([
'**/docusaurus.config.ts',
'**/test/**/*.{js,ts}',
'**/tests/**/*.{js,ts}',
'scripts/*.ts',
'scripts/create-package/**/*.ts',
'scripts/**/*.{ts,mts}',
'packages/platform-api-docs/**/*.ts',
],
ignores: ['scripts/create-package/package-template/**/*.ts'],
extends: [nodejs],
},
{
Expand All @@ -130,7 +130,7 @@ const config = createConfig([
},
},
{
files: ['**/*.ts'],
files: ['**/*.ts', '**/*.mts'],
extends: [typescript],
languageOptions: {
parserOptions: {
Expand Down
6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,18 @@
"docs:platform-api:build": "yarn workspace @metamask/platform-api-docs cli ../.. --build --project-label Core",
"docs:platform-api:dev": "yarn workspace @metamask/platform-api-docs cli ../.. --dev --project-label Core",
"docs:platform-api:serve": "yarn workspace @metamask/platform-api-docs cli ../.. --serve --project-label Core",
"lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check",
"lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check && yarn lint:tsconfigs:all",
"lint:dependencies": "knip --dependencies && yarn dedupe --check",
"lint:dependencies:fix": "knip --dependencies && yarn dedupe",
"lint:eslint": "yarn build:only-clean && NODE_OPTIONS='--max-old-space-size=8192' yarn eslint",
"lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn messenger-action-types:generate && yarn readme-content:update",
"lint:misc": "oxfmt --ignore-path .gitignore",
"lint:misc:check": "yarn lint:misc --check",
"lint:teams": "tsx scripts/lint-teams-json.ts",
"lint:tsconfigs": "tsx scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs",
"lint:tsconfigs:fix": "tsx scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"lint:tsconfigs:fix:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs:fix",
"messenger-action-types:check": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:check",
"messenger-action-types:generate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:generate",
"postinstall": "yarn skills:postinstall",
Expand Down
2 changes: 2 additions & 0 deletions packages/account-tree-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/account-tree-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/account-tree-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/accounts-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/accounts-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
15 changes: 12 additions & 3 deletions packages/accounts-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,18 @@
{
"path": "../base-controller/tsconfig.build.json"
},
{ "path": "../keyring-controller/tsconfig.build.json" },
{ "path": "../network-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" }
{
"path": "../keyring-controller/tsconfig.build.json"
},
{
"path": "../network-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
},
{
"path": "../controller-utils/tsconfig.build.json"

@mcmire mcmire Apr 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is present in devDependencies but was missing as a reference.

}
],
"include": ["../../types", "./src"]
}
11 changes: 9 additions & 2 deletions packages/accounts-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,15 @@
{
"path": "../keyring-controller"
},
{ "path": "../network-controller" },
{ "path": "../messenger" }
{
"path": "../network-controller"
},
{
"path": "../messenger"
},
{
"path": "../controller-utils"

@mcmire mcmire Apr 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is present in devDependencies but was missing as a reference.

}
],
"include": ["../../types", "./src", "./tests"]
}
2 changes: 2 additions & 0 deletions packages/address-book-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/address-book-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/address-book-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/ai-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/ai-controllers",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/ai-controllers",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/analytics-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/analytics-data-regulation-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-data-regulation-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-data-regulation-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/announcement-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/announcement-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/announcement-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
3 changes: 3 additions & 0 deletions packages/app-metadata-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/app-metadata-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/app-metadata-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -61,6 +63,7 @@
"deepmerge": "^4.2.2",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"tsx": "^4.20.5",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "~5.3.3"
Expand Down
2 changes: 2 additions & 0 deletions packages/approval-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/approval-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/approval-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
2 changes: 2 additions & 0 deletions packages/assets-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/assets-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/assets-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
59 changes: 48 additions & 11 deletions packages/assets-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,54 @@
"rootDir": "./src"
},
"references": [
{ "path": "../account-tree-controller/tsconfig.build.json" },
{ "path": "../assets-controllers/tsconfig.build.json" },
{ "path": "../base-controller/tsconfig.build.json" },
{ "path": "../client-controller/tsconfig.build.json" },
{ "path": "../core-backend/tsconfig.build.json" },
{ "path": "../keyring-controller/tsconfig.build.json" },
{ "path": "../messenger/tsconfig.build.json" },
{ "path": "../network-enablement-controller/tsconfig.build.json" },
{ "path": "../permission-controller/tsconfig.build.json" },
{ "path": "../phishing-controller/tsconfig.build.json" },
{ "path": "../preferences-controller/tsconfig.build.json" }
{
"path": "../account-tree-controller/tsconfig.build.json"
},
{
"path": "../assets-controllers/tsconfig.build.json"
},
{
"path": "../base-controller/tsconfig.build.json"
},
{
"path": "../client-controller/tsconfig.build.json"
},
{
"path": "../core-backend/tsconfig.build.json"
},
{
"path": "../keyring-controller/tsconfig.build.json"
},
{
"path": "../messenger/tsconfig.build.json"
},
{
"path": "../network-enablement-controller/tsconfig.build.json"
},
{
"path": "../permission-controller/tsconfig.build.json"
},
{
"path": "../phishing-controller/tsconfig.build.json"
},
{
"path": "../preferences-controller/tsconfig.build.json"
},
{
"path": "../accounts-controller/tsconfig.build.json"

@mcmire mcmire Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All references starting with accounts-controller are present in dependencies but were missing.

},
{
"path": "../controller-utils/tsconfig.build.json"
},
{
"path": "../network-controller/tsconfig.build.json"
},
{
"path": "../polling-controller/tsconfig.build.json"
},
{
"path": "../transaction-controller/tsconfig.build.json"
}
],
"include": ["../../types", "./src"],
"exclude": ["**/*.test.ts", "**/__fixtures__/"]
Expand Down
58 changes: 48 additions & 10 deletions packages/assets-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,54 @@
"baseUrl": "./"
},
"references": [
{ "path": "../account-tree-controller" },
{ "path": "../assets-controllers" },
{ "path": "../base-controller" },
{ "path": "../client-controller" },
{ "path": "../core-backend" },
{ "path": "../keyring-controller" },
{ "path": "../messenger" },
{ "path": "../network-enablement-controller" },
{ "path": "../phishing-controller" },
{ "path": "../preferences-controller" }
{
"path": "../account-tree-controller"
},
{
"path": "../assets-controllers"
},
{
"path": "../base-controller"
},
{
"path": "../client-controller"
},
{
"path": "../core-backend"
},
{
"path": "../keyring-controller"
},
{
"path": "../messenger"
},
{
"path": "../network-enablement-controller"
},
{
"path": "../phishing-controller"
},
{
"path": "../preferences-controller"
},
{
"path": "../accounts-controller"

@mcmire mcmire Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All references starting with accounts-controller are present in dependencies but were missing.

},
{
"path": "../controller-utils"
},
{
"path": "../network-controller"
},
{
"path": "../permission-controller"
},
{
"path": "../polling-controller"
},
{
"path": "../transaction-controller"
}
],
"include": ["../../types", "./src"]
}
2 changes: 2 additions & 0 deletions packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
"build:docs": "typedoc",
"changelog:update": "../../scripts/update-changelog.sh @metamask/assets-controllers",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/assets-controllers",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
Expand Down
Loading
Loading