Skip to content

chore: remove vestigial lint scripts from migrated packages - #9048

Merged
cryptodev-2s merged 1 commit into
mainfrom
chore/remove-vestigial-lint-scripts
Jun 8, 2026
Merged

chore: remove vestigial lint scripts from migrated packages#9048
cryptodev-2s merged 1 commit into
mainfrom
chore/remove-vestigial-lint-scripts

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Explanation

json-rpc-engine, eth-json-rpc-provider, eth-block-tracker and eth-json-rpc-middleware were imported into the monorepo from their own standalone repos (see docs/processes/package-migration-process-guide.md). Each kept the per-package lint scripts the standalone repo had:

"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:dependencies",
"lint:dependencies": "depcheck",
"lint:eslint": "eslint .  --ext js,ts",
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:dependencies",
"lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",

None of the 80+ packages born in the monorepo have these scripts, and the scripts/create-package/package-template doesn't include them either — the root-level lint:eslint, lint:misc, lint:dependencies, etc. already cover all packages. The bins these scripts call (eslint, prettier, depcheck) are root-only devDependencies, and Yarn 4 does not expose those to a workspace script context (yarn workspace <pkg> run lint:eslint fails with command not found: eslint), so these scripts have been dead code since migration.

This PR removes all five scripts from the four affected packages so they match the rest of the monorepo. No CI workflow or root script references them.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Package.json script cleanup only; no runtime, API, or CI lint behavior changes.

Overview
Removes vestigial per-package lint scripts (lint, lint:eslint, lint:fix, lint:misc, lint:dependencies) from four packages that were migrated from standalone repos: @metamask/eth-block-tracker, @metamask/eth-json-rpc-middleware, @metamask/eth-json-rpc-provider, and @metamask/json-rpc-engine.

Their package.json scripts sections now match native monorepo packages (build, test, changelog only). Linting is unchanged in practice—root lint / lint:eslint / lint:misc / lint:dependencies already cover the whole repo; the removed workspace scripts were non-functional under Yarn 4 because tooling bins live at the root.

Reviewed by Cursor Bugbot for commit 5fcd130. Bugbot is set up for automated code reviews on this repo. Configure here.

`json-rpc-engine`, `eth-json-rpc-provider`, `eth-block-tracker` and
`eth-json-rpc-middleware` were imported from standalone repos and
kept their per-package `lint`, `lint:eslint`, `lint:fix`,
`lint:misc`, and `lint:dependencies` scripts. None of the 80+
packages born in the monorepo (nor the `create-package` template)
have these scripts — the root scripts handle all linting. The
hoisted bins (`eslint`, `prettier`, `depcheck`) aren't visible to a
per-package script context anyway, so these have been dead code
since migration. Drop them so the migrated packages match the rest
of the monorepo.
@cryptodev-2s
cryptodev-2s requested review from a team as code owners June 8, 2026 18:39
@cryptodev-2s cryptodev-2s self-assigned this Jun 8, 2026
@cryptodev-2s
cryptodev-2s enabled auto-merge June 8, 2026 18:43
@cryptodev-2s
cryptodev-2s added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 857f758 Jun 8, 2026
375 of 376 checks passed
@cryptodev-2s
cryptodev-2s deleted the chore/remove-vestigial-lint-scripts branch June 8, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants