chore: remove vestigial lint scripts from migrated packages - #9048
Merged
Conversation
`json-rpc-engine`, `eth-json-rpc-provider`, `eth-block-tracker` and `eth-json-rpc-middleware` were imported from standalone repos and kept their per-package `lint`, `lint:eslint`, `lint:fix`, `lint:misc`, and `lint:dependencies` scripts. None of the 80+ packages born in the monorepo (nor the `create-package` template) have these scripts — the root scripts handle all linting. The hoisted bins (`eslint`, `prettier`, `depcheck`) aren't visible to a per-package script context anyway, so these have been dead code since migration. Drop them so the migrated packages match the rest of the monorepo.
cryptodev-2s
temporarily deployed
to
default-branch
June 8, 2026 18:39 — with
GitHub Actions
Inactive
4 tasks
cryptodev-2s
enabled auto-merge
June 8, 2026 18:43
Mrtenz
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
json-rpc-engine,eth-json-rpc-provider,eth-block-trackerandeth-json-rpc-middlewarewere imported into the monorepo from their own standalone repos (seedocs/processes/package-migration-process-guide.md). Each kept the per-package lint scripts the standalone repo had:None of the 80+ packages born in the monorepo have these scripts, and the
scripts/create-package/package-templatedoesn't include them either — the root-levellint:eslint,lint:misc,lint:dependencies, etc. already cover all packages. The bins these scripts call (eslint,prettier,depcheck) are root-only devDependencies, and Yarn 4 does not expose those to a workspace script context (yarn workspace <pkg> run lint:eslintfails withcommand not found: eslint), so these scripts have been dead code since migration.This PR removes all five scripts from the four affected packages so they match the rest of the monorepo. No CI workflow or root script references them.
References
N/A
Checklist
Note
Low Risk
Package.json script cleanup only; no runtime, API, or CI lint behavior changes.
Overview
Removes vestigial per-package lint scripts (
lint,lint:eslint,lint:fix,lint:misc,lint:dependencies) from four packages that were migrated from standalone repos:@metamask/eth-block-tracker,@metamask/eth-json-rpc-middleware,@metamask/eth-json-rpc-provider, and@metamask/json-rpc-engine.Their
package.jsonscripts sections now match native monorepo packages (build, test, changelog only). Linting is unchanged in practice—rootlint/lint:eslint/lint:misc/lint:dependenciesalready cover the whole repo; the removed workspace scripts were non-functional under Yarn 4 because tooling bins live at the root.Reviewed by Cursor Bugbot for commit 5fcd130. Bugbot is set up for automated code reviews on this repo. Configure here.