chore: remove unused deps in core-platform packages

README.md

@@ -282,7 +282,6 @@ linkStyle default opacity:0.5
   authenticated_user_storage --> controller_utils;
   authenticated_user_storage --> messenger;
   base_controller --> messenger;
-  base_controller --> json_rpc_engine;
   base_data_service --> controller_utils;
   base_data_service --> messenger;
   bridge_controller --> accounts_controller;
@@ -369,7 +368,6 @@ linkStyle default opacity:0.5
   eth_json_rpc_middleware --> eth_json_rpc_provider;
   eth_json_rpc_middleware --> json_rpc_engine;
   eth_json_rpc_middleware --> message_manager;
-  eth_json_rpc_middleware --> network_controller;
   eth_json_rpc_provider --> json_rpc_engine;
   gas_fee_controller --> base_controller;
   gas_fee_controller --> controller_utils;
@@ -483,7 +481,6 @@ linkStyle default opacity:0.5
   phishing_controller --> messenger;
   phishing_controller --> transaction_controller;
   polling_controller --> base_controller;
-  polling_controller --> controller_utils;
   polling_controller --> network_controller;
   polling_controller --> messenger;
   preferences_controller --> base_controller;

knip.config.ts

@@ -45,9 +45,6 @@ const config: KnipConfig = {
         'bitcoin-address-validation',
       ],
     },
-    'packages/base-controller': {
-      ignoreDependencies: ['@metamask/json-rpc-engine'],
-    },
     'packages/bridge-controller': {
       ignoreDependencies: [
         '@metamask/eth-json-rpc-provider',
@@ -81,9 +78,6 @@ const config: KnipConfig = {
     'packages/ens-controller': {
       ignoreDependencies: ['punycode'],
     },
-    'packages/eth-json-rpc-middleware': {
-      ignoreDependencies: ['@metamask/network-controller', 'pify', 'tsd'],
-    },
     'packages/foundryup': {
       // `anvil` and `sysctl` are external system binaries, not npm packages.
       ignoreBinaries: ['anvil', 'sysctl'],
@@ -101,9 +95,6 @@ const config: KnipConfig = {
     'packages/message-manager': {
       ignoreDependencies: ['@metamask/eth-sig-util', 'immer', 'jsonschema'],
     },
-    'packages/messenger-cli': {
-      ignoreDependencies: ['eslint'],
-    },
     'packages/multichain-account-service': {
       ignoreDependencies: [
         '@metamask/base-controller',
@@ -117,15 +108,9 @@ const config: KnipConfig = {
     'packages/multichain-transactions-controller': {
       ignoreDependencies: ['@metamask/polling-controller'],
     },
-    'packages/network-controller': {
-      ignoreDependencies: ['async-mutex'],
-    },
     'packages/phishing-controller': {
       ignoreDependencies: ['immer', 'punycode'],
     },
-    'packages/polling-controller': {
-      ignoreDependencies: ['@metamask/controller-utils'],
-    },
     'packages/profile-metrics-controller': {
       ignoreDependencies: ['cockatiel'],
     },
@@ -173,13 +158,22 @@ const config: KnipConfig = {
       ignoreDependencies: ['immer'],
     },
     'packages/wallet-framework-docs': {
+      // Source lives under `site/` instead of `src/`; tell knip to scan it
+      // so the type imports of `@docusaurus/*` / `prism-react-renderer` in
+      // `docusaurus.config.ts` and `sidebars.ts` are seen and the matching
+      // devDeps don't get flagged as unused.
+      entry: ['site/docusaurus.config.ts', 'site/sidebars.ts'],
+      project: ['site/**/*.{ts,tsx}'],
       ignoreDependencies: [
-        '@docusaurus/plugin-content-docs',
-        '@docusaurus/preset-classic',
-        '@docusaurus/theme-common',
-        '@docusaurus/types',
+        // Loaded by docusaurus as a plugin name string (themes[0]); knip
+        // doesn't trace string-referenced plugins.
         '@easyops-cn/docusaurus-search-local',
-        'prism-react-renderer',
+        // Pulled in transitively by `@docusaurus/preset-classic`; pinned
+        // here so the framework's webpack/theme resolution finds a single
+        // matching version.
+        '@docusaurus/theme-common',
+        // Webpack loader used by docusaurus' build pipeline; never imported
+        // by source.
         'raw-loader',
       ],
     },

packages/base-controller/package.json

@@ -56,7 +56,6 @@
   },
   "devDependencies": {
     "@metamask/auto-changelog": "^6.1.0",
-    "@metamask/json-rpc-engine": "^10.5.0",
     "@ts-bridge/cli": "^0.6.4",
     "@types/jest": "^29.5.14",
     "deepmerge": "^4.2.2",

packages/eth-json-rpc-middleware/CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Bump `@metamask/json-rpc-engine` from `^10.2.4` to `^10.5.0` ([#8661](https://github.com/MetaMask/core/pull/8661), [#8746](https://github.com/MetaMask/core/pull/8746), [#8753](https://github.com/MetaMask/core/pull/8753))
 - Bump `@metamask/message-manager` from `^14.1.1` to `^14.1.2` ([#8755](https://github.com/MetaMask/core/pull/8755))
+- Drop `pify` dependency, which was no longer used in source ([#9064](https://github.com/MetaMask/core/pull/9064))
 
 ## [23.1.3]
 

packages/eth-json-rpc-middleware/package.json

@@ -61,20 +61,16 @@
     "@metamask/superstruct": "^3.1.0",
     "@metamask/utils": "^11.9.0",
     "klona": "^2.0.6",
-    "pify": "^5.0.0",
     "safe-stable-stringify": "^2.4.3"
   },
   "devDependencies": {
     "@metamask/auto-changelog": "^6.1.0",
-    "@metamask/network-controller": "^32.0.0",
     "@ts-bridge/cli": "^0.6.4",
     "@types/deep-freeze-strict": "^1.1.0",
     "@types/jest": "^29.5.14",
-    "@types/pify": "^5.0.2",
     "deep-freeze-strict": "^1.1.1",
     "deepmerge": "^4.2.2",
     "jest": "^29.7.0",
-    "tsd": "^0.31.2",
     "typedoc": "^0.25.13",
     "typescript": "~5.3.3"
   },

packages/messenger-cli/package.json

@@ -47,7 +47,6 @@
     "@types/jest": "^29.5.14",
     "@types/yargs": "^17.0.32",
     "deepmerge": "^4.2.2",
-    "eslint": "^9.39.1",
     "execa": "^5.0.0",
     "jest": "^29.7.0",
     "oxfmt": "^0.44.0",

packages/network-controller/CHANGELOG.md

@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - The constructor argument `isRpcFailoverEnabled` is no longer available.
   - `RemoteFeatureFlagController:stateChange` and `RemoteFeatureFlagController:getState` are now required.
 - Bump `@metamask/controller-utils` from `^12.1.0` to `^12.1.1` ([#9058](https://github.com/MetaMask/core/pull/9058))
+- Drop `async-mutex` dependency, which was no longer used in source ([#9064](https://github.com/MetaMask/core/pull/9064))
 
 ### Removed
 

packages/network-controller/package.json

@@ -67,7 +67,6 @@
     "@metamask/rpc-errors": "^7.0.2",
     "@metamask/swappable-obj-proxy": "^2.3.0",
     "@metamask/utils": "^11.9.0",
-    "async-mutex": "^0.5.0",
     "fast-deep-equal": "^3.1.3",
     "immer": "^9.0.6",
     "loglevel": "^1.8.1",

packages/polling-controller/CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- Bump `@metamask/controller-utils` from `^12.1.0` to `^12.1.1` ([#9058](https://github.com/MetaMask/core/pull/9058))
+- Drop `@metamask/controller-utils` dependency, which was no longer used in source ([#9058](https://github.com/MetaMask/core/pull/9058), [#9064](https://github.com/MetaMask/core/pull/9064))
 
 ## [16.0.6]
 

packages/polling-controller/package.json

@@ -52,7 +52,6 @@
   },
   "dependencies": {
     "@metamask/base-controller": "^9.1.0",
-    "@metamask/controller-utils": "^12.1.1",
     "@metamask/network-controller": "^32.0.0",
     "@metamask/utils": "^11.9.0",
     "@types/uuid": "^8.3.0",