fix(wallet-cli): retry sendCommand only on ECONNREFUSED - #9608
Merged
Conversation
The daemon client's `sendCommand` retried a request once on both ECONNREFUSED and ECONNRESET. ECONNRESET can drop after the daemon has already received and acted on the request, so blindly re-sending a non-idempotent request (e.g. a transaction broadcast) could execute it twice. Restrict the retry to ECONNREFUSED — where the connection was never established, so the daemon provably never received the request — and surface ECONNRESET to the caller instead. This hardens the retry path before any mutating send/sign/transfer RPC becomes reachable over the daemon socket. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sirtimid
marked this pull request as ready for review
July 22, 2026 16:19
sirtimid
enabled auto-merge
July 22, 2026 16:20
rekmarks
approved these changes
Jul 22, 2026
3 tasks
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Jul 28, 2026
## Explanation Adds the user-facing `mm wallet send` command that sends a transaction end-to-end through the daemon-hosted `TransactionController`, closing MetaMask#9513. This is the CLI surface on top of the daemon's transaction capability (MetaMask#9512 / MetaMask#9612): it collects transaction parameters, dispatches them to the daemon, waits for the broadcast, and reports the resulting transaction hash. Send a transaction. `--value` is in ether; select the network with `--network-client-id` or `--chain-id`; the sender defaults to the selected account. The command previews the resolved plan and asks for confirmation before broadcasting, then prints the transaction hash: Because the daemon auto-approves the confirmation prompt — or your explicit `--yes` — is the only boundary before funds move; use `--dry-run` first if unsure. Gas is estimated automatically unless overridden with `--gas` / `--max-fee-per-gas` / `--max-priority-fee-per-gas` / `--gas-price` (each a `0x`-prefixed hex quantity). ### Dedicated `sendTransaction` RPC handler `TransactionController:addTransaction` returns a `Result` shaped like `{ transactionMeta, result }`, where `result` is a `Promise<hash>` that resolves once the transaction is signed and broadcast. That promise is **not JSON-serializable**, so it cannot travel back over the daemon's generic `call` dispatch. The daemon therefore exposes a dedicated `sendTransaction` handler (`src/daemon/send-transaction.ts`) that, server-side: 1. resolves the network client — from `networkClientId`, or from `chainId` via `NetworkController:findNetworkClientIdByChainId`; 2. resolves the sender — the provided `--from`, or the selected account; 3. calls `addTransaction(txParams, { networkClientId, origin: 'metamask', isInternal: true })` (internal, so it skips origin/permitted-account validation and is auto-approved by the headless daemon); 4. **awaits the broadcast** and re-reads the live record so the returned status reflects the post-broadcast state (`submitted`), not the `unapproved` creation snapshot; 5. returns a serializable `{ transactionHash, transactionId, status }`. Params are validated with superstruct at the daemon boundary (exactly one of `networkClientId` / `chainId`; `0x` address and hex quantities). ### The `mm wallet send` command A thin client over that handler (`src/commands/wallet/send.ts`): ```sh ➜ wallet-cli: yarn mm wallet send --help Send a transaction through the daemon-hosted TransactionController. Estimates gas automatically unless overridden, signs, broadcasts, and prints the resulting transaction hash. The daemon auto-approves, so the confirmation boundary is this command. USAGE $ mm wallet send --to <value> [--value <value>] [--from <value>] [--data <value>] [--network-client-id <value>] [--chain-id <value>] [--gas <value>] [--max-fee-per-gas <value>] [--max-priority-fee-per-gas <value>] [--gas-price <value>] [--dry-run] [-y] [-t <value>] FLAGS -t, --timeout=<value> Response timeout in milliseconds -y, --yes Skip the confirmation prompt and broadcast immediately. --chain-id=<value> Chain ID (0x-prefixed hex) to resolve to a network client. Provide this or --network-client-id, not both. --data=<value> Calldata as a 0x-prefixed hex string (for contract calls) --dry-run Resolve the network client and sender and validate params, but do not broadcast. --from=<value> Sender address (0x-prefixed). Defaults to the selected account. --gas=<value> Gas limit override, as a 0x-prefixed hex quantity --gas-price=<value> Legacy gasPrice override, as a 0x-prefixed hex wei quantity --max-fee-per-gas=<value> maxFeePerGas override, as a 0x-prefixed hex wei quantity --max-priority-fee-per-gas=<value> maxPriorityFeePerGas override, as a 0x-prefixed hex wei quantity --network-client-id=<value> Network client to send on. Provide this or --chain-id, not both. --to=<value> (required) Recipient address (0x-prefixed) --value=<value> [default: 0] Amount to send, in ether (e.g. 0.01). Defaults to 0. EXAMPLES $ mm wallet send --to 0xRecipient --value 0.01 --chain-id 0x1 $ mm wallet send --to 0xRecipient --value 0.01 --network-client-id mainnet --yes $ mm wallet send --to 0xContract --data 0xabcdef --value 0 --chain-id 0x1 --dry-run ``` ## Testing - Unit tests for the handler (network/sender resolution, internal submit, dry-run, broadcast + live status, param validation) and the command (arg parsing, preview/confirm/abort, `--yes`, `--dry-run`, error surfaces); **100% coverage maintained**. - **Real-chain e2e** (`tests/wallet-send.e2e.test.ts`): boots a local `anvil` node, adds it as a custom network, and drives the built `mm` CLI to sign, broadcast, and mine a real transaction (asserts receipt `status: 0x1` and a recipient balance increase). It is **skip-if-absent**; CI installs `anvil` for it only when `packages/wallet-cli/` changed. See `packages/wallet-cli/tests/README.md`. - `build`, package `test`, `test:e2e`, `yarn lint`, `changelog:validate` pass. ## References - Closes MetaMask#9513 - Builds on MetaMask#9512 / MetaMask#9611 (daemon transaction-capable) and MetaMask#9509 (the `TransactionController` slot); the mutating-RPC safety prerequisite MetaMask#9511 landed in MetaMask#9608. - `packages/wallet-cli/src/daemon/send-transaction.ts`, `src/commands/wallet/send.ts`, `tests/wallet-send.e2e.test.ts`. > [!NOTE] > Stacked on `sirtimid/wallet-cli-daemon-transaction-capable` (MetaMask#9612); this PR is based on that branch so the diff is scoped. Once MetaMask#9612 merges, this will be rebased onto `main` and retargeted. ## Checklist - [x] Tests cover the handler and command (unit) plus a real-chain broadcast (e2e); 100% coverage maintained. - [x] `build`, `test`, `test:e2e`, `yarn lint:fix`, `yarn lint`, `changelog:validate` pass. - [x] Confirmation prompt (`--yes` to skip) and `--dry-run` gate a real, irreversible send. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Adds an irreversible on-chain send path through a headless daemon that auto-approves transactions; mistakes in confirmation, `--yes`, or timeout/retry behavior could move real funds despite CLI safeguards. > > **Overview** > Introduces **`mm wallet send`** so users can broadcast through the daemon-hosted `TransactionController`, with ether `--value`, network selection via `--network-client-id` or `--chain-id`, optional gas overrides, **`--dry-run`**, and an interactive preview (or **`--yes`** to skip). > > Because `addTransaction`'s broadcast promise cannot cross JSON-RPC, the daemon gains a dedicated **`sendTransaction`** handler that resolves network/sender, submits as internal/auto-approved, awaits the hash, and returns `{ transactionHash, transactionId, status }` (with **`dryRun`** for preview-only). > > The CLI dry-runs before confirm, then pins the resolved **`from`** / **`networkClientId`** on broadcast; it validates RPC results, uses a longer default broadcast timeout with duplicate-send warnings on timeout, and documents that the daemon still auto-approves—so the command prompt is the main fund-moving gate. > > **CI/testing:** wallet-cli e2e installs **anvil** via `@metamask/foundryup`, sets **`MM_E2E_REQUIRE_ANVIL`**, adds a real-chain send e2e (anvil + custom network), shares daemon cleanup helpers, and updates knip/README/changelog accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0f0e34f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
wallet-cli's daemon clientsendCommandretried a failed request once on bothECONNREFUSEDandECONNRESET. OnlyECONNREFUSEDis safe to retry — it means the connection was never established, so the daemon never received the request.ECONNRESETcan drop after the daemon received and acted on the request, so a blind resend could execute a non-idempotent action (e.g. broadcast a transaction) twice.This restricts the retry to
ECONNREFUSED;ECONNRESETnow surfaces to the caller (wheremakeDaemonConnectionErroralready renders a distinct "lost the connection to the daemon" message). Updates thesendCommandandPingUnreachableReasonJSDoc accordingly.Latent today (all current callers are idempotent), but a prerequisite for shipping any send/sign/transfer command.
References
wallet-cli: makesendCommandretry idempotency-safe before mutating RPC ships #9511wallet-cli: add themmsend-transaction command #9513Checklist
Note
Medium Risk
Changes daemon RPC failure semantics in a wallet CLI path that will back send/sign flows; the tradeoff is correct for safety but callers may see more surfaced connection errors instead of silent retries.
Overview
Narrows daemon JSON-RPC client retry behavior so
sendCommandretries once only onECONNREFUSED, not onECONNRESET. A reset can happen after the daemon already handled the request, so a blind resend could run a non-idempotent action (e.g. broadcast) twice; those errors now propagate to callers instead.pingDaemonstill classifiesECONNRESETas unreachable with reasonrefused, but inherits the no-retry rule viasendCommand. JSDoc, changelog, and tests were updated to match.Reviewed by Cursor Bugbot for commit 1fa26b8. Bugbot is set up for automated code reviews on this repo. Configure here.